2007-10-27 14:50:38

by Roel Kluin

Subject: [PATCH] fix 'and' typos in drivers/block/pktcdvd.c

Fix two 'and' typos

Signed-off-by: Roel Kluin <[email protected]>
---
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index a8130a4..9cd6ba2 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -2202,11 +2202,11 @@ static int pkt_media_speed(struct pktcdvd_device *pd, unsigned *speed)
return ret;
}

- if (!buf[6] & 0x40) {
+ if (!(buf[6] & 0x40)) {
printk(DRIVER_NAME": Disc type is not CD-RW\n");
return 1;
}
- if (!buf[6] & 0x4) {
+ if (!(buf[6] & 0x4)) {
printk(DRIVER_NAME": A1 values on media are not valid, maybe not CDRW?\n");
return 1;
}

2007-10-27 16:53:25

by Alexey Dobriyan

Subject: Re: [PATCH] fix 'and' typos in drivers/block/pktcdvd.c

On Sat, Oct 27, 2007 at 04:50:27PM +0200, Roel Kluin wrote:
> --- a/drivers/block/pktcdvd.c
> +++ b/drivers/block/pktcdvd.c
> @@ -2202,11 +2202,11 @@ static int pkt_media_speed(struct pktcdvd_device *pd, unsigned *speed)
> return ret;
> }
>
> - if (!buf[6] & 0x40) {
> + if (!(buf[6] & 0x40)) {
> printk(DRIVER_NAME": Disc type is not CD-RW\n");
> return 1;
> }
> - if (!buf[6] & 0x4) {
> + if (!(buf[6] & 0x4)) {

Roel, many of this were fixed during
"+ fix-vm_can_nonlinear-check-in-sys_remap_file_pages.patch added to -mm tree"
thread. Please, check patches in there and send what was missed.