On Mon, 29 Oct 2007, Tilman Schmidt wrote:
> From: Tilman Schmidt <[email protected]>
>
> Add basic suspend/resume support to the usb_gigaset driver.
> @@ -117,6 +122,11 @@ static struct usb_driver gigaset_usb_dri
> .probe = gigaset_probe,
> .disconnect = gigaset_disconnect,
> .id_table = gigaset_table,
> + .suspend = gigaset_suspend,
> + .resume = gigaset_resume,
> + .reset_resume = gigaset_resume,
> + .pre_reset = gigaset_suspend,
> + .post_reset = gigaset_resume,
> };
Does this really compile? The .pre_reset and .suspend members are
pointers to functions with different prototypes; I don't see how you
can assign the same function to both pointers.
Alan Stern
Am 29.10.2007 20:10 schrieb Alan Stern:
> On Mon, 29 Oct 2007, Tilman Schmidt wrote:
>
>> From: Tilman Schmidt <[email protected]>
>>
>> Add basic suspend/resume support to the usb_gigaset driver.
>
>> @@ -117,6 +122,11 @@ static struct usb_driver gigaset_usb_dri
>> .probe = gigaset_probe,
>> .disconnect = gigaset_disconnect,
>> .id_table = gigaset_table,
>> + .suspend = gigaset_suspend,
>> + .resume = gigaset_resume,
>> + .reset_resume = gigaset_resume,
>> + .pre_reset = gigaset_suspend,
>> + .post_reset = gigaset_resume,
>> };
>
> Does this really compile? The .pre_reset and .suspend members are
> pointers to functions with different prototypes; I don't see how you
> can assign the same function to both pointers.
Oops, you're right. Yes, it does compile, but with a warning
"initialization from incompatible pointer type" which I
foolishly ignored.
I'll produce a corrected version promptly.
Thanks,
Tilman
--
Tilman Schmidt E-Mail: [email protected]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Unge?ffnet mindestens haltbar bis: (siehe R?ckseite)