2006-09-30 18:21:00

by Vincent Legoll

[permalink] [raw]

Subject: [PATCH] off-by-one in kernel command line option parsing

---

fix memcmp() off-by-one
nolapic is 7 chars long

---
commit aa2cb4b05c437005ccff44084678948c99aa62b3
tree 54ddca6ab0ef9a29bb1ff0f452b1eaccce7b33a1
parent 4ed4b5475211fab6a0ad00eed2f9297395e7598e
author Vincent Legoll <[email protected]> Sat, 30 Sep 2006 18:52:53 +0200
committer Vincent Legoll <[email protected]> Sat, 30 Sep 2006 18:52:53 +0200

arch/i386/kernel/setup.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c
index f168220..72bbf22 100644
--- a/arch/i386/kernel/setup.c
+++ b/arch/i386/kernel/setup.c
@@ -869,7 +869,7 @@ #ifdef CONFIG_X86_LOCAL_APIC
lapic_enable();

/* disable local APIC */
- else if (!memcmp(from, "nolapic", 6))
+ else if (!memcmp(from, "nolapic", 7))
lapic_disable();
#endif /* CONFIG_X86_LOCAL_APIC */

---

Attachments:

opt-parse.patch (845.00 B)

2006-09-30 18:25:25

by Andi Kleen

[permalink] [raw]

Subject: Re: [PATCH] off-by-one in kernel command line option parsing

---

On Saturday 30 September 2006 20:20, Vincent Legoll wrote:
> Here is a patch for what I think is a bug in the kernel,
> please comment / apply as appropriate.


That code is already gone in the latest tree.

-Andi

2006-09-30 18:32:42

by Vincent Legoll

[permalink] [raw]

Subject: Re: [PATCH] off-by-one in kernel command line option parsing

---

On 9/30/06, Andi Kleen <[email protected]> wrote:
> That code is already gone in the latest tree.

OK, I fumbled with git and checked a not-so-recent
snapshot. Sorry for the noise.

--
Vincent Legoll