2007-11-13 18:29:15

by Jochen Friedrich

Subject: [PATCH] powerpc: Add support for PORTA and PORTB odr registers

PORTA and PORTB have odr registers, as well. However, the PORTB odr
register is only 16bit.

Signed-off-by: Jochen Friedrich <[email protected]>
---
arch/powerpc/sysdev/commproc.c | 13 +++++++++++++
1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/sysdev/commproc.c b/arch/powerpc/sysdev/commproc.c
index d5a0dcf..3694a69 100644
--- a/arch/powerpc/sysdev/commproc.c
+++ b/arch/powerpc/sysdev/commproc.c
@@ -441,6 +441,13 @@ static void cpm1_set_pin32(int port, int pin, int flags)
else
clrbits32(&iop->par, pin);

+ if (port == CPM_PORTB) {
+ if (flags & CPM_PIN_OPENDRAIN)
+ setbits16(&mpc8xx_immr->im_cpm.cp_pbodr, pin);
+ else
+ clrbits16(&mpc8xx_immr->im_cpm.cp_pbodr, pin);
+ }
+
if (port == CPM_PORTE) {
if (flags & CPM_PIN_SECONDARY)
setbits32(&iop->sor, pin);
@@ -474,6 +481,12 @@ static void cpm1_set_pin16(int port, int pin, int flags)
else
clrbits16(&iop->par, pin);

+ if (port == CPM_PORTA) {
+ if (flags & CPM_PIN_OPENDRAIN)
+ setbits16(&iop->odr, pin);
+ else
+ clrbits16(&iop->odr, pin);
+ }
if (port == CPM_PORTC) {
if (flags & CPM_PIN_SECONDARY)
setbits16(&iop->sor, pin);
--
1.5.3.5

2007-11-13 23:47:10

by Scott Wood

Subject: Re: [PATCH] powerpc: Add support for PORTA and PORTB odr registers

Jochen Friedrich wrote:
> @@ -474,6 +481,12 @@ static void cpm1_set_pin16(int port, int pin, int
> flags)
> else
> clrbits16(&iop->par, pin);
>
> + if (port == CPM_PORTA) {
> + if (flags & CPM_PIN_OPENDRAIN)
> + setbits16(&iop->odr, pin);
> + else
> + clrbits16(&iop->odr, pin);
> + }
> if (port == CPM_PORTC) {
> if (flags & CPM_PIN_SECONDARY)
> setbits16(&iop->sor, pin);

Where is the odr field of cpm_ioport16 defined? It's the same position
as sor, so maybe call it odr_sor or something.

Also, please add an extra newline after the closing brace.

-Scott