2024-01-17 12:14:24

by Daniel Abrecht

Subject: [PATCH] ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to dmi_blacklist

In U-Boot, the default for DMI vendor / product if not set is "Unknown"
and "Unknown Product".
See
https://source.denx.de/u-boot/u-boot/-/blob/v2023.10/lib/smbios.c?ref_type=tags#L272

This patch adds them to the dmi_blacklist.

Signed-off-by: Daniel Abrecht <[email protected]>
---
sound/soc/soc-core.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index f8524b5bfb33..aa1a31abbe3a 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1804,6 +1804,8 @@ static const char * const dmi_blacklist[] = {
"Board Manufacturer",
"Board Vendor Name",
"Board Product Name",
+ "Unknown",
+ "Unknown Product",
NULL, /* terminator */
};

--
2.39.2

2024-01-17 12:26:28

by Jaroslav Kysela

Subject: Re: [PATCH] ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to dmi_blacklist

On 17. 01. 24 13:14, Daniel Abrecht wrote:
> In U-Boot, the default for DMI vendor / product if not set is "Unknown"
> and "Unknown Product".
> See
> https://source.denx.de/u-boot/u-boot/-/blob/v2023.10/lib/smbios.c?ref_type=tags#L272
>
> This patch adds them to the dmi_blacklist.
>
> Signed-off-by: Daniel Abrecht <[email protected]>

I think that there's a whitespace issue, but for the contents:

Acked-by: Jaroslav Kysela <[email protected]>


> ---
> sound/soc/soc-core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index f8524b5bfb33..aa1a31abbe3a 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -1804,6 +1804,8 @@ static const char * const dmi_blacklist[] = {
> "Board Manufacturer",
> "Board Vendor Name",
> "Board Product Name",
> + "Unknown",
> + "Unknown Product",
> NULL, /* terminator */
> };
>

--
Jaroslav Kysela <[email protected]>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

2024-01-17 13:43:43

by Daniel Abrecht

Subject: Re: [PATCH] ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to dmi_blacklist

Am 2024-01-17 13:20, schrieb Jaroslav Kysela:
> On 17. 01. 24 13:14, Daniel Abrecht wrote:
>> In U-Boot, the default for DMI vendor / product if not set is
>> "Unknown"
>> and "Unknown Product".
>> See
>> https://source.denx.de/u-boot/u-boot/-/blob/v2023.10/lib/smbios.c?ref_type=tags#L272
>>
>> This patch adds them to the dmi_blacklist.
>>
>> Signed-off-by: Daniel Abrecht <[email protected]>
>
> I think that there's a whitespace issue, but for the contents:
>
> Acked-by: Jaroslav Kysela <[email protected]>

Sorry about the whitespace thing. I'll try again.