2007-11-21 14:23:52

by Robert Hancock

[permalink] [raw]
Subject: Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v2)

Vincent Fortier wrote:
> Le mardi 20 novembre 2007 ? 18:56 -0600, Robert Hancock a ?crit :
>> This fixes some problems with ATAPI devices on nForce4 controllers in ADMA
>> mode on systems with memory located above 4GB. We need to delay setting the
>> 64-bit DMA mask until the PRD table and padding buffer are allocated so that
>> they don't get allocated above 4GB and break legacy mode (which is needed for
>> ATAPI devices). Also, explicitly set a 32-bit DMA mask before allocating the
>> legacy buffers since setting the DMA mask affects both ports and we need to
>> ensure the second port's buffers are allocated properly (fixes a problem
>> with the previous version of this patch).
>>
>> Signed-off-by: Robert Hancock <[email protected]>
>>
>
> Would this be worth sending to stable team for 2.6.22 & 2.6.23 ?

Likely (after it gets merged), those versions would have the same bug..