2007-12-04 10:45:42

by Lukas Hejtmanek

[permalink] [raw]
Subject: PATCH: Hitachi disk quirk

Hello,

the following patch should be applied into 2.6.24-rc3 as the mentioned Hitachi
disk has also problem with NCQ.

--
Luk?? Hejtm?nek

Attachments:
(No filename) (140.00 B)
 ata.patch (587.00 B)
 Download all attachments

2007-12-04 11:48:37

by Michael Tokarev

[permalink] [raw]
Subject: Re: PATCH: Hitachi disk quirk

Lukas Hejtmanek wrote:
> Hello,
>
> the following patch should be applied into 2.6.24-rc3 as the mentioned Hitachi
> disk has also problem with NCQ.

Which problems, exactly?

Note that recent massive "NCQ horkage" isn't necessary due to drives fault.
Search for "spurious completions during NCQ" for recent discussions
(many of them).

> --- a/drivers/ata/libata-core.c 2007-12-04 11:08:20.000000000 +0100
> +++ b/drivers/ata/libata-core.c 2007-12-04 11:09:23.000000000 +0100
> { "Hitachi HTS541616J9SA00", "SB4OC70P", ATA_HORKAGE_NONCQ, },
> + { "HITACHI HTS541616J9SA00", "SB4IC7UP", ATA_HORKAGE_NONCQ, },
> { "Hitachi HTS542525K9SA00", "BBFOC31P", ATA_HORKAGE_NONCQ, },

/mjt

2007-12-04 12:31:40

by Lukas Hejtmanek

[permalink] [raw]
Subject: Re: PATCH: Hitachi disk quirk

On Tue, Dec 04, 2007 at 02:48:27PM +0300, Michael Tokarev wrote:
> Which problems, exactly?

it is spurious completitions and I saw that because of that the drives are
blacklisted. Moreover, the same drive is already blacklisted but with
different firmware.

> Note that recent massive "NCQ horkage" isn't necessary due to drives fault.
> Search for "spurious completions during NCQ" for recent discussions
> (many of them).
>
> > --- a/drivers/ata/libata-core.c 2007-12-04 11:08:20.000000000 +0100
> > +++ b/drivers/ata/libata-core.c 2007-12-04 11:09:23.000000000 +0100
> > { "Hitachi HTS541616J9SA00", "SB4OC70P", ATA_HORKAGE_NONCQ, },
> > + { "HITACHI HTS541616J9SA00", "SB4IC7UP", ATA_HORKAGE_NONCQ, },
> > { "Hitachi HTS542525K9SA00", "BBFOC31P", ATA_HORKAGE_NONCQ, },
>
> /mjt

--
Luk?? Hejtm?nek