Two comments refer to deadlines applying to reads only. This is
not the case.
Signed-off-by: Aaron Carroll <[email protected]>
---
block/as-iosched.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/as-iosched.c b/block/as-iosched.c
index dc715a5..4513fc5 100644
--- a/block/as-iosched.c
+++ b/block/as-iosched.c
@@ -880,7 +880,7 @@ static void as_remove_queued_request(struct request_queue *q,
}
/*
- * as_fifo_expired returns 0 if there are no expired reads on the fifo,
+ * as_fifo_expired returns 0 if there are no expired requests on the fifo,
* 1 otherwise. It is ratelimited so that we only perform the check once per
* `fifo_expire' interval. Otherwise a large number of expired requests
* would create a hopeless seekstorm.
@@ -1159,7 +1159,7 @@ static void as_add_request(struct request_queue *q, struct request *rq)
as_add_rq_rb(ad, rq);
/*
- * set expire time (only used for reads) and add to fifo list
+ * set expire time and add to fifo list
*/
rq_set_fifo_time(rq, jiffies + ad->fifo_expire[data_dir]);
list_add_tail(&rq->queuelist, &ad->fifo_list[data_dir]);
--
On Wed, Dec 05, 2007 at 09:06:50PM +1100, Aaron Carroll wrote:
> Two comments refer to deadlines applying to reads only. This is
> not the case.
>
> Signed-off-by: Aaron Carroll <[email protected]>
Acked-by: Nick Piggin <[email protected]>
> ---
> block/as-iosched.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/as-iosched.c b/block/as-iosched.c
> index dc715a5..4513fc5 100644
> --- a/block/as-iosched.c
> +++ b/block/as-iosched.c
> @@ -880,7 +880,7 @@ static void as_remove_queued_request(struct request_queue *q,
> }
>
> /*
> - * as_fifo_expired returns 0 if there are no expired reads on the fifo,
> + * as_fifo_expired returns 0 if there are no expired requests on the fifo,
> * 1 otherwise. It is ratelimited so that we only perform the check once per
> * `fifo_expire' interval. Otherwise a large number of expired requests
> * would create a hopeless seekstorm.
> @@ -1159,7 +1159,7 @@ static void as_add_request(struct request_queue *q, struct request *rq)
> as_add_rq_rb(ad, rq);
>
> /*
> - * set expire time (only used for reads) and add to fifo list
> + * set expire time and add to fifo list
> */
> rq_set_fifo_time(rq, jiffies + ad->fifo_expire[data_dir]);
> list_add_tail(&rq->queuelist, &ad->fifo_list[data_dir]);
> --
On Wed, Dec 05 2007, Nick Piggin wrote:
> On Wed, Dec 05, 2007 at 09:06:50PM +1100, Aaron Carroll wrote:
> > Two comments refer to deadlines applying to reads only. This is
> > not the case.
> >
> > Signed-off-by: Aaron Carroll <[email protected]>
>
> Acked-by: Nick Piggin <[email protected]>
Goodie, I'll apply this one as well.
--
Jens Axboe