sparsemem-make-sparsemem-vmemmap-selectable.patch introduces a little bug.
SPARSEMEM_VMEMMAP can be enabled in an architecture that doesn't support it. If the
architecture supports SPARSEMEM_VMEMMAP, SPARSEMEM_VMEMMAP_ENABLE is enabled,
so SPARSEMEM_VMEMMAP should depend on it.
Signed-off-by: Miguel Botón <[email protected]>
diff --git a/mm/Kconfig b/mm/Kconfig
index c0f5cbb..010a261 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -117,8 +117,8 @@ config SPARSEMEM_VMEMMAP_ENABLE
config SPARSEMEM_VMEMMAP
bool "Sparse Memory virtual memmap"
- depends on SPARSEMEM
- default y if (SPARSEMEM_VMEMMAP_ENABLE)
+ depends on SPARSEMEM_VMEMMAP_ENABLE
+ default y
help
SPARSEMEM_VMEMMAP uses a virtually mapped memmap to optimise
pfn_to_page and page_to_pfn operations. This is the most
--
Miguel Botón
Previous patch had another bug. This one works fine.
Signed-off-by: Miguel Botón <[email protected]>
diff --git a/mm/Kconfig b/mm/Kconfig
index 010a261..9ef9741 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -117,7 +117,7 @@ config SPARSEMEM_VMEMMAP_ENABLE
config SPARSEMEM_VMEMMAP
bool "Sparse Memory virtual memmap"
- depends on SPARSEMEM_VMEMMAP_ENABLE
+ depends on SPARSEMEM && SPARSEMEM_VMEMMAP_ENABLE
default y
help
SPARSEMEM_VMEMMAP uses a virtually mapped memmap to optimise
--
Miguel Botón
On 12/08/2007 11:30 AM, Miguel Bot?n wrote:
> sparsemem-make-sparsemem-vmemmap-selectable.patch introduces a little bug.
>
> SPARSEMEM_VMEMMAP can be enabled in an architecture that doesn't support it. If the
> architecture supports SPARSEMEM_VMEMMAP, SPARSEMEM_VMEMMAP_ENABLE is enabled,
> so SPARSEMEM_VMEMMAP should depend on it.
sparsemem-make-sparsemem-vmemmap-selectable.patch is still only in my
ps3-linux-patches.git development repo. I'll just fold this into the
original patch. Thanks.
-Geoff