2007-12-12 02:34:13

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB fixes


Em Ter, 2007-12-11 às 21:14 -0500, Michael Krufky escreveu:
> Mauro Carvalho Chehab wrote:
> > Please pull from:
> > ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git master
> >
> > [snip]
> >
> >
> Mauro,
> > Mauro Carvalho Chehab (4):
> > V4L/DVB (6750): Fix in-kernel compilation for cxusb
> >
> ^^ This patch fixes a build issue that only applies to new devices that
> depend on the tuner-xc2028 module, which is planned to be added to
> mainline for 2.6.25 .... We don't need to send this patch upstream yet,
> because the dependency doesn't exist in 2.6.24.

Hmm... ok. Anyway, It won't hurt to apply it. The patch just adds a
missing include directory to Makefile:
+EXTRA_CFLAGS += -Idrivers/media/video

Anyway, I'll remove it from the tree and send to linus an updated pull
request.

> > Benoit Istin (1):
> > V4L/DVB (6746): saa7134-dvb: fix tuning for WinTV HVR-1110
> >
> >
> ^^ This patch is good for 2.6.24, but it is only the first half of the
> fix. This fixes digital tuning, but the analog fix is the following
> changeset:
>
> saa7134: enable LNA in analog mode for Hauppauge WinTV HVR-1110
> http://linuxtv.org/hg/~mkrufky/oxford2/rev/b227949c41ad
>
> Please send this one in your next pull request to Linus.
Ok.

I'll pull from your oxford2 tree and keep it for a while at development tree for testing.

> Regards,
>
> Mike
--
Cheers,
Mauro


2007-12-12 02:37:29

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB fixes

> > ^^ This patch fixes a build issue that only applies to new devices
> that
> > depend on the tuner-xc2028 module, which is planned to be added to
> > mainline for 2.6.25 .... We don't need to send this patch upstream yet,
> > because the dependency doesn't exist in 2.6.24.
>
> Hmm... ok. Anyway, It won't hurt to apply it. The patch just adds a
> missing include directory to Makefile:
> +EXTRA_CFLAGS += -Idrivers/media/video
>
> Anyway, I'll remove it from the tree and send to linus an updated pull
> request.

Linus already pulled from my tree. There's no need to revert this
changeset. It will not hurt and will be needed soon, anyway.

--
Cheers,
Mauro

2007-12-12 03:11:19

by Michael Ira Krufky

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB fixes

Mauro Carvalho Chehab wrote:
>>> ^^ This patch fixes a build issue that only applies to new devices
>>>
>> that
>>
>>> depend on the tuner-xc2028 module, which is planned to be added to
>>> mainline for 2.6.25 .... We don't need to send this patch upstream yet,
>>> because the dependency doesn't exist in 2.6.24.
>>>
>> Hmm... ok. Anyway, It won't hurt to apply it. The patch just adds a
>> missing include directory to Makefile:
>> +EXTRA_CFLAGS += -Idrivers/media/video
>>
>> Anyway, I'll remove it from the tree and send to linus an updated pull
>> request.
>>
>
> Linus already pulled from my tree. There's no need to revert this
> changeset. It will not hurt and will be needed soon, anyway.
>
That's fine -- it doesn't hurt anything.

Cheers,

Mike