2007-12-17 16:06:21

by Roel Kluin

[permalink] [raw]
Subject: [PATCH drivers/isdn/hardware/eicon/message.c] fix 'and' typo in eicons' AddInfo()

I have previously sent this to [email protected] and its
maintainer, but the error is still in linus' tree.
--
'!' has a higher priority than '&', so as was the bit test masks a binary.

Signed-off-by: Roel Kluin <[email protected]>
---
diff --git a/drivers/isdn/hardware/eicon/message.c b/drivers/isdn/hardware/eicon/message.c
index ccd35d0..189b231 100644
--- a/drivers/isdn/hardware/eicon/message.c
+++ b/drivers/isdn/hardware/eicon/message.c
@@ -9027,7 +9027,7 @@ static byte AddInfo(byte **add_i,
/* facility is a nested structure */
/* FTY can be more than once */

- if(esc_chi[0] && !(esc_chi[esc_chi[0]])&0x7f )
+ if (esc_chi[0] && !(esc_chi[esc_chi[0]] & 0x7f))
{
add_i[0] = (byte *)"\x02\x02\x00"; /* use neither b nor d channel */
}