2007-12-28 00:51:53

by Tomohiro Kusumi

[permalink] [raw]
Subject: [PATCH] remove val in __do_proc_dointvec

Hi

What's the purpose of the val in __do_proc_dointvec ?
It seems no one ever uses this val.

Tomohiro Kusumi
Signed-off-by: Tomohiro Kusumi <[email protected]>

diff -Nur linux-2.6.23.org/kernel/sysctl.c linux-2.6.23/kernel/sysctl.c
--- linux-2.6.23.org/kernel/sysctl.c 2007-12-28 09:29:18.000000000 +0900
+++ linux-2.6.23/kernel/sysctl.c 2007-12-28 09:31:32.000000000 +0900
@@ -1716,7 +1716,7 @@
void *data)
{
#define TMPBUFLEN 21
- int *i, vleft, first=1, neg, val;
+ int *i, vleft, first=1, neg;
unsigned long lval;
size_t left, len;

@@ -1769,8 +1769,6 @@
len = p-buf;
if ((len < left) && *p && !isspace(*p))
break;
- if (neg)
- val = -val;
s += len;
left -= len;