2014-04-23 03:48:01

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build failure after merge of the wireless-next tree

---

Hi John,

After merging the wireless-next tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/wireless/mwifiex/pcie.c: In function 'mwifiex_pcie_fw_dump_work':
drivers/net/wireless/mwifiex/pcie.c:2290:3: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration]
entry->mem_ptr = vmalloc(memory_size + 1);
^
drivers/net/wireless/mwifiex/pcie.c:2290:18: warning: assignment makes pointer from integer without a cast [enabled by default]
entry->mem_ptr = vmalloc(memory_size + 1);
^
drivers/net/wireless/mwifiex/pcie.c:2361:4: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
vfree(entry->mem_ptr);
^

Caused by commit e050c76fcf49 ("mwifiex: add firmware dump feature for
PCIe").

I have applied this patch for today:

From: Stephen Rothwell <[email protected]>
Date: Wed, 23 Apr 2014 13:44:59 +1000
Subject: [PATCH] mwifiex: using vmallog requires including vmalloc.h

Signed-off-by: Stephen Rothwell <[email protected]>
---
drivers/net/wireless/mwifiex/pcie.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/mwifiex/pcie.c b/drivers/net/wireless/mwifiex/pcie.c
index 51989b31137a..9c1f42754bbe 100644
--- a/drivers/net/wireless/mwifiex/pcie.c
+++ b/drivers/net/wireless/mwifiex/pcie.c
@@ -17,6 +17,7 @@
* this warranty disclaimer.
*/

+#include <linux/vmalloc.h>
#include <linux/firmware.h>

#include "decl.h"
--
1.9.2

--
Cheers,
Stephen Rothwell [email protected]

---

Attachments:

(No filename) (1.53 kB)
(No filename) (836.00 B)
Download all attachments

2014-04-23 20:54:45

by Bing Zhao

[permalink] [raw]

Subject: RE: linux-next: build failure after merge of the wireless-next tree

---

Hi Stephen,

> Hi John,
>
> After merging the wireless-next tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/net/wireless/mwifiex/pcie.c: In function 'mwifiex_pcie_fw_dump_work':
> drivers/net/wireless/mwifiex/pcie.c:2290:3: error: implicit declaration of function 'vmalloc' [-
> Werror=implicit-function-declaration]
> entry->mem_ptr = vmalloc(memory_size + 1);
> ^
> drivers/net/wireless/mwifiex/pcie.c:2290:18: warning: assignment makes pointer from integer without a
> cast [enabled by default]
> entry->mem_ptr = vmalloc(memory_size + 1);
> ^
> drivers/net/wireless/mwifiex/pcie.c:2361:4: error: implicit declaration of function 'vfree' [-
> Werror=implicit-function-declaration]
> vfree(entry->mem_ptr);
> ^
>
> Caused by commit e050c76fcf49 ("mwifiex: add firmware dump feature for
> PCIe").
>
> I have applied this patch for today:


Sorry for the trouble and thanks a lot for the fix.

Regards,
Bing


>
> From: Stephen Rothwell <[email protected]>
> Date: Wed, 23 Apr 2014 13:44:59 +1000
> Subject: [PATCH] mwifiex: using vmallog requires including vmalloc.h
>
> Signed-off-by: Stephen Rothwell <[email protected]>
> ---
> drivers/net/wireless/mwifiex/pcie.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/mwifiex/pcie.c b/drivers/net/wireless/mwifiex/pcie.c
> index 51989b31137a..9c1f42754bbe 100644
> --- a/drivers/net/wireless/mwifiex/pcie.c
> +++ b/drivers/net/wireless/mwifiex/pcie.c
> @@ -17,6 +17,7 @@
> * this warranty disclaimer.
> */
>
> +#include <linux/vmalloc.h>
> #include <linux/firmware.h>
>
> #include "decl.h"
> --
> 1.9.2
>
> --
> Cheers,
> Stephen Rothwell [email protected]