2014-04-23 13:00:50

by Jan Moskyto Matejka

Subject: [PATCH][linux-next] wireless: fixed bad dev_info integer type warning

The pointer difference (ptrdiff_t) should be formatted by %tx, not %lx.

Signed-off-by: Jan Moskyto Matejka <[email protected]>
---
drivers/net/wireless/mwifiex/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mwifiex/pcie.c b/drivers/net/wireless/mwifiex/pcie.c
index 9c1f427..e04141a 100644
--- a/drivers/net/wireless/mwifiex/pcie.c
+++ b/drivers/net/wireless/mwifiex/pcie.c
@@ -2321,7 +2321,7 @@ static void mwifiex_pcie_fw_dump_work(struct work_struct *work)
if (stat != RDWR_STATUS_DONE)
continue;

- dev_info(adapter->dev, "%s done: size=0x%lx\n",
+ dev_info(adapter->dev, "%s done: size=0x%tx\n",
entry->mem_name, dbg_ptr - entry->mem_ptr);
memset(filename, 0, sizeof(filename));
memcpy(filename, name_prefix, strlen(name_prefix));
--
1.8.4.5

2014-04-23 20:56:10

by Bing Zhao

Subject: RE: [PATCH][linux-next] wireless: fixed bad dev_info integer type warning

Hi Jan,

Thanks for the patch.

> The pointer difference (ptrdiff_t) should be formatted by %tx, not %lx.
>
> Signed-off-by: Jan Moskyto Matejka <[email protected]>

Acked-by: Bing Zhao <[email protected]>

Regards,
Bing

> ---
> drivers/net/wireless/mwifiex/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mwifiex/pcie.c b/drivers/net/wireless/mwifiex/pcie.c
> index 9c1f427..e04141a 100644
> --- a/drivers/net/wireless/mwifiex/pcie.c
> +++ b/drivers/net/wireless/mwifiex/pcie.c
> @@ -2321,7 +2321,7 @@ static void mwifiex_pcie_fw_dump_work(struct work_struct *work)
> if (stat != RDWR_STATUS_DONE)
> continue;
>
> - dev_info(adapter->dev, "%s done: size=0x%lx\n",
> + dev_info(adapter->dev, "%s done: size=0x%tx\n",
> entry->mem_name, dbg_ptr - entry->mem_ptr);
> memset(filename, 0, sizeof(filename));
> memcpy(filename, name_prefix, strlen(name_prefix));
> --
> 1.8.4.5