2008-01-10 12:33:17

by Paul Chavent

[permalink] [raw]
Subject: Usb generic serial.

Hello and happy new year 2008.

In drivers/usb/serial/usb-serial.c there is a function (fixup_generic /
set_to_generic_if_null) that hooks null fops to the generic driver ones.

The drivers/usb/serial/generic.c implements throttle, unthrottle and
resume, but those aren't used by default in fixup_generic. Is there any
reasons ? Could we submit a patch for that ?

Thank you for your help.




2008-01-24 01:51:34

by Greg KH

[permalink] [raw]
Subject: Re: Usb generic serial.

On Thu, Jan 10, 2008 at 01:29:27PM +0100, Paul Chavent wrote:
> Hello and happy new year 2008.
>
> In drivers/usb/serial/usb-serial.c there is a function (fixup_generic /
> set_to_generic_if_null) that hooks null fops to the generic driver ones.
>
> The drivers/usb/serial/generic.c implements throttle, unthrottle and
> resume, but those aren't used by default in fixup_generic. Is there any
> reasons ? Could we submit a patch for that ?

Do you have a driver that needs to use these throttle/unthrottle and
resume functions? If so, we can change things to use them, but so far,
it hasn't been needed.

thanks,

greg k-h