2008-01-18 03:41:44

by Dmitri Vorobiev

[permalink] [raw]
Subject: [PATCH] x86_32: remove the useless NR_syscalls macro

This is against current x86.git.

The size of the system call table for 32-bit x86 kernels is obtained by
compile-time calculation of the sys_call_table array, not from the value,
which the NR_syscalls macro expands to. This trivial patch removes the
fossil macro.

Manually tested by grepping the x86 files for the "NR_syscalls" string.
No relevant use cases found.

Build-tested using allyesconfig, allnoconfig and a couple of randconfig
instances. All builds successfully finished.

Runtime test performed using a stripped-down Debian-ish config. The system
booted successfully.

Signed-off-by: Dmitri Vorobiev <[email protected]>
---
include/asm-x86/unistd_32.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/include/asm-x86/unistd_32.h b/include/asm-x86/unistd_32.h
index 9b15545..8d8f9b5 100644
--- a/include/asm-x86/unistd_32.h
+++ b/include/asm-x86/unistd_32.h
@@ -333,8 +333,6 @@ #define __NR_fallocate 324

#ifdef __KERNEL__

-#define NR_syscalls 325
-
#define __ARCH_WANT_IPC_PARSE_VERSION
#define __ARCH_WANT_OLD_READDIR
#define __ARCH_WANT_OLD_STAT
--
1.4.1


2008-01-18 08:13:25

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH] x86_32: remove the useless NR_syscalls macro


* Dmitri Vorobiev <[email protected]> wrote:

> This is against current x86.git.
>
> The size of the system call table for 32-bit x86 kernels is obtained
> by compile-time calculation of the sys_call_table array, not from the
> value, which the NR_syscalls macro expands to. This trivial patch
> removes the fossil macro.
>
> Manually tested by grepping the x86 files for the "NR_syscalls"
> string. No relevant use cases found.
>
> Build-tested using allyesconfig, allnoconfig and a couple of
> randconfig instances. All builds successfully finished.
>
> Runtime test performed using a stripped-down Debian-ish config. The
> system booted successfully.

thanks, applied.

Ingo