2008-01-30 14:55:32

by Roel Kluin

Subject: [PATCH][drivers/usb/gadget/amd5536udc.c] duplicate use_dma_ppb_du => 2nd use_dma_ppb

Untested patch below, please confirm it's the right fix.
--
duplicate use_dma_ppb_du, 2nd should be use_dma_ppb

Signed-off-by: Roel Kluin <[email protected]>
---
diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
index c72e962..fbc10f9 100644
--- a/drivers/usb/gadget/amd5536udc.c
+++ b/drivers/usb/gadget/amd5536udc.c
@@ -205,7 +205,7 @@ static void print_regs(struct udc *dev)
DBG(dev, "DMA mode = PPBNDU (packet per buffer "
"WITHOUT desc. update)\n");
dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBNDU");
- } else if (use_dma && use_dma_ppb_du && use_dma_ppb_du) {
+ } else if (use_dma && use_dma_ppb && use_dma_ppb_du) {
DBG(dev, "DMA mode = PPBDU (packet per buffer "
"WITH desc. update)\n");
dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBDU");

2008-01-31 10:31:52

by Thomas Dahlmann

Subject: Re: [PATCH][drivers/usb/gadget/amd5536udc.c] duplicate use_dma_ppb_du => 2nd use_dma_ppb

This fix is correct.

Thanks,
Thomas

Roel Kluin wrote:
> Untested patch below, please confirm it's the right fix.
> --
> duplicate use_dma_ppb_du, 2nd should be use_dma_ppb
>
> Signed-off-by: Roel Kluin <[email protected]>
> ---
> diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
> index c72e962..fbc10f9 100644
> --- a/drivers/usb/gadget/amd5536udc.c
> +++ b/drivers/usb/gadget/amd5536udc.c
> @@ -205,7 +205,7 @@ static void print_regs(struct udc *dev)
> DBG(dev, "DMA mode = PPBNDU (packet per buffer "
> "WITHOUT desc. update)\n");
> dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBNDU");
> - } else if (use_dma && use_dma_ppb_du && use_dma_ppb_du) {
> + } else if (use_dma && use_dma_ppb && use_dma_ppb_du) {
> DBG(dev, "DMA mode = PPBDU (packet per buffer "
> "WITH desc. update)\n");
> dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBDU");
>
>
>