2008-02-05 12:15:46

by Rami Rosen

[permalink] [raw]
Subject: [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set.

Hi,

When CONFIG_PROC_FS is not set and CONFIG_PPPOL2TP is set,
we have the following warning in build:
drivers/net/pppol2tp.c: In function 'pppol2tp_init':
drivers/net/pppol2tp.c:2472: warning: label
'out_unregister_pppox_proto' defined but not used

This patches fixes this warning by adding appropriate #ifdef.

Regards,
Rami Rosen


Signed-off-by: Rami Rosen <[email protected]>

Attachments:
(No filename) (388.00 B)
 patch.txt (420.00 B)
 Download all attachments

2008-02-05 17:38:27

by James Chapman

[permalink] [raw]
Subject: Re: [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set.

Acked-by: James Chapman <[email protected]>

Rami Rosen wrote:
> Hi,
>
> When CONFIG_PROC_FS is not set and CONFIG_PPPOL2TP is set,
> we have the following warning in build:
> drivers/net/pppol2tp.c: In function 'pppol2tp_init':
> drivers/net/pppol2tp.c:2472: warning: label
> 'out_unregister_pppox_proto' defined but not used
>
> This patches fixes this warning by adding appropriate #ifdef.
>
> Regards,
> Rami Rosen
>
>
> Signed-off-by: Rami Rosen <[email protected]>
>


--
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development

2008-02-05 18:22:33

by Jeff Garzik

[permalink] [raw]
Subject: Re: [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set.

Rami Rosen wrote:
> Hi,
>
> When CONFIG_PROC_FS is not set and CONFIG_PPPOL2TP is set,
> we have the following warning in build:
> drivers/net/pppol2tp.c: In function 'pppol2tp_init':
> drivers/net/pppol2tp.c:2472: warning: label
> 'out_unregister_pppox_proto' defined but not used
>
> This patches fixes this warning by adding appropriate #ifdef.
>
> Regards,
> Rami Rosen
>
>
> Signed-off-by: Rami Rosen <[email protected]>


David or Paul, wanna pick this up?

2008-02-06 00:31:00

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set.

From: James Chapman <[email protected]>
Date: Tue, 05 Feb 2008 17:38:10 +0000

> Acked-by: James Chapman <[email protected]>

Applied, thanks everyone.

2008-02-06 00:31:49

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set.

From: Jeff Garzik <[email protected]>
Date: Tue, 05 Feb 2008 13:22:19 -0500

> David or Paul, wanna pick this up?

I took it, no worries.