2008-02-12 22:03:35

by H. Peter Anvin

Subject: [PATCH] timeconst.pl: correct reversal of USEC_TO_HZ and HZ_TO_USEC

The USEC_TO_HZ and HZ_TO_USEC constant sets were mislabelled, with
seriously incorrect results. This among other things manifested
itself as cpufreq not working when a tickless kernel was configured.

Signed-off-by: H. Peter Anvin <[email protected]>
---
kernel/timeconst.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/timeconst.pl b/kernel/timeconst.pl
index 62b1287..4146803 100644
--- a/kernel/timeconst.pl
+++ b/kernel/timeconst.pl
@@ -339,7 +339,7 @@ sub output($@)
print "\n";

foreach $pfx ('HZ_TO_MSEC','MSEC_TO_HZ',
- 'USEC_TO_HZ','HZ_TO_USEC') {
+ 'HZ_TO_USEC','USEC_TO_HZ') {
foreach $bit (32, 64) {
foreach $suf ('MUL', 'ADJ', 'SHR') {
printf "#define %-23s %s\n",
--
1.5.3.8

2008-02-12 22:21:48

by Carlos R. Mafra

Subject: Re: [PATCH] timeconst.pl: correct reversal of USEC_TO_HZ and HZ_TO_USEC

H. Peter Anvin wrote:
> The USEC_TO_HZ and HZ_TO_USEC constant sets were mislabelled, with
> seriously incorrect results. This among other things manifested
> itself as cpufreq not working when a tickless kernel was configured.
>
> Signed-off-by: H. Peter Anvin <[email protected]>


Tested-by: Carlos R. Mafra <[email protected]>


> ---
> kernel/timeconst.pl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/timeconst.pl b/kernel/timeconst.pl
> index 62b1287..4146803 100644
> --- a/kernel/timeconst.pl
> +++ b/kernel/timeconst.pl
> @@ -339,7 +339,7 @@ sub output($@)
> print "\n";
>
> foreach $pfx ('HZ_TO_MSEC','MSEC_TO_HZ',
> - 'USEC_TO_HZ','HZ_TO_USEC') {
> + 'HZ_TO_USEC','USEC_TO_HZ') {
> foreach $bit (32, 64) {
> foreach $suf ('MUL', 'ADJ', 'SHR') {
> printf "#define %-23s %s\n",