2008-02-13 21:40:31

by Adrian Bunk

Subject: [2.6 patch] scsi_transport_iscsi.c: make 2 functions static

This patch makes the following needlessly global functions static:
- __iscsi_unblock_session()
- iscsi_session_state_name()

Signed-off-by: Adrian Bunk <[email protected]>

---

drivers/scsi/scsi_transport_iscsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

c7b0a4c74538d3a53cd7325a5ad0f2ae774ebb94 diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index fac7534..9981682 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -231,7 +231,7 @@ static struct {
{ ISCSI_SESSION_FREE, "FREE" },
};

-const char *iscsi_session_state_name(int state)
+static const char *iscsi_session_state_name(int state)
{
int i;
char *name = NULL;
@@ -373,7 +373,7 @@ static void session_recovery_timedout(struct work_struct *work)
scsi_target_unblock(&session->dev);
}

-void __iscsi_unblock_session(struct iscsi_cls_session *session)
+static void __iscsi_unblock_session(struct iscsi_cls_session *session)
{
if (!cancel_delayed_work(&session->recovery_work))
flush_workqueue(iscsi_eh_timer_workq);

2008-02-14 18:31:37

by Mike Christie

Subject: Re: [2.6 patch] scsi_transport_iscsi.c: make 2 functions static

Adrian Bunk wrote:
> This patch makes the following needlessly global functions static:
> - __iscsi_unblock_session()
> - iscsi_session_state_name()
>
> Signed-off-by: Adrian Bunk <[email protected]>
>

Looks good. Thanks.

Acked-by: Mike Christie <[email protected]>