2008-02-26 11:40:25

by Josh Triplett

[permalink] [raw]
Subject: Re: + rcu-split-listh-and-move-rcu-protected-lists-into-rculisth.patch added to -mm tree

[I did not see this patch go by on any mailing list, so I replied to
the -mm mail and CCed LKML.]

[email protected] wrote:
> The patch titled
> rcu: split list.h and move rcu-protected lists into rculist.h
> has been added to the -mm tree. Its filename is
> rcu-split-listh-and-move-rcu-protected-lists-into-rculisth.patch
[...]
> Subject: rcu: split list.h and move rcu-protected lists into rculist.h
> From: Franck Bui-Huu <[email protected]>
>
> Move rcu-protected lists from list.h into a new header file rculist.h.
>
> This is done because list are a very used primitive structure all over the
> kernel and it's currently impossible to include other header files in this
> list.h without creating some circular dependencies.
>
> For example, list.h implements rcu-protected list and uses rcu_dereference()
> without including rcupdate.h. It actually compiles because users of
> rcu_dereference() are macros. Others RCU functions could be used too but
> aren't probably because of this.
>
> Therefore this patch creates rculist.h which includes rcupdates without to
> many changes/troubles.
>
> Signed-off-by: Franck Bui-Huu <[email protected]>
> Acked-by: Paul E. McKenney <[email protected]>
> Cc: Josh Triplett <[email protected]>
> Signed-off-by: Andrew Morton <[email protected]>

This seems fine to me. Having the headers separate might make it more
difficult to keep the two in sync, but the list primitives don't
change, so that doesn't really matter much.

Acked-by: Josh Triplett <[email protected]>

- Josh Triplett


2008-02-26 18:31:52

by Franck Bui-Huu

[permalink] [raw]
Subject: Re: + rcu-split-listh-and-move-rcu-protected-lists-into-rculisth.patch added to -mm tree

Hi,

Josh Triplett wrote:
> [I did not see this patch go by on any mailing list, so I replied to
> the -mm mail and CCed LKML.]
>

Well I'm pretty sure to have always CC'ed LKML, see for example:

http://lkml.org/lkml/2008/2/19/150
http://lkml.org/lkml/2008/2/19/151

Thanks,
Franck

2008-02-26 19:11:13

by Josh Triplett

[permalink] [raw]
Subject: Re: + rcu-split-listh-and-move-rcu-protected-lists-into-rculisth.patch added to -mm tree

Franck Bui-Huu wrote:
> Josh Triplett wrote:
>> [I did not see this patch go by on any mailing list, so I replied to
>> the -mm mail and CCed LKML.]
>>
>
> Well I'm pretty sure to have always CC'ed LKML, see for example:
>
> http://lkml.org/lkml/2008/2/19/150
> http://lkml.org/lkml/2008/2/19/151

I must have missed it when I dug through the archive. Thanks.

- Josh Triplett