2008-03-19 23:21:28

by Masami Hiramatsu

[permalink] [raw]
Subject: Re: [PATCH] kprobes: correct regs->ip value in post_hander()

Yakov Lerner wrote:
> From: "Yakov Lerner" <[email protected]>
>
> This patch corrects the value of regs->ip in post_handler(). Prior to
> this patch, post_handler() was given address meaningless to the user in
> regs->ip. The expected value is address of the next instruction to be
> executed after kprobed instruction. This patch simply swaps the order of
> post_handler() and resume_execution(). post_handler() now sees the
> corrected, expected value in regs->ip. post_handler() is now called after
> after resume_execution(), not before.
>
> Only x86 platform was tested. Arm arch needs no changes.
>
> Signed-off-by: Yakov Lerner <[email protected]>

Thank you, I tested this on x86-64/x86/ia64.

Acked-by: Masami Hiramatsu <[email protected]>


--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: [email protected]