2008-03-19 19:24:31

by Andre Noll

[permalink] [raw]
Subject: Fix permissions of /proc/net

commit f205a545ee62e0f0f797c1e2b0bd2062d96414b3
Author: Andre Noll <[email protected]>
Date: Wed Mar 19 11:39:55 2008 +0100

From: Andre Noll <[email protected]>

commit e9720ac ([NET]: Make /proc/net a symlink on /proc/self/net (v3))
broke ganglia and probably other applications that read /proc/net/dev.

This is due to the change of permissions of /proc/net that was
introduced in that commit.

Before: dr-xr-xr-x 5 root root 0 Mar 19 11:30 /proc/net
After: dr-xr--r-- 5 root root 0 Mar 19 11:29 /proc/self/net

This patch restores the permissions to the old value which makes ganglia
happy again.

Signed-off-by: Andre Noll <[email protected]>

diff --git a/fs/proc/base.c b/fs/proc/base.c
index 8a10f6f..81d7d14 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -2290,7 +2290,7 @@ static const struct pid_entry tgid_base_stuff[] = {
DIR("fd", S_IRUSR|S_IXUSR, fd),
DIR("fdinfo", S_IRUSR|S_IXUSR, fdinfo),
#ifdef CONFIG_NET
- DIR("net", S_IRUGO|S_IXUSR, net),
+ DIR("net", S_IRUGO|S_IXUGO, net),
#endif
REG("environ", S_IRUSR, environ),
INF("auxv", S_IRUSR, pid_auxv),
--
The only person who always got his work done by Friday was Robinson Crusoe


Attachments:
(No filename) (1.18 kB)
signature.asc (189.00 B)
Digital signature
Download all attachments

2008-03-20 07:57:56

by Pavel Emelyanov

[permalink] [raw]
Subject: Re: Fix permissions of /proc/net

Andre Noll wrote:
> commit f205a545ee62e0f0f797c1e2b0bd2062d96414b3
> Author: Andre Noll <[email protected]>
> Date: Wed Mar 19 11:39:55 2008 +0100
>
> From: Andre Noll <[email protected]>
>
> commit e9720ac ([NET]: Make /proc/net a symlink on /proc/self/net (v3))
> broke ganglia and probably other applications that read /proc/net/dev.

This also broke the postfix, as it was reported in bug #10286
and described in detail by Benjamin.

> This is due to the change of permissions of /proc/net that was
> introduced in that commit.
>
> Before: dr-xr-xr-x 5 root root 0 Mar 19 11:30 /proc/net
> After: dr-xr--r-- 5 root root 0 Mar 19 11:29 /proc/self/net
>
> This patch restores the permissions to the old value which makes ganglia
> happy again.

And it fixes the problem reported by Benjamin.
Thanks, Andre!

> Signed-off-by: Andre Noll <[email protected]>

Acked-by: Pavel Emelyanov <[email protected]>

> diff --git a/fs/proc/base.c b/fs/proc/base.c
> index 8a10f6f..81d7d14 100644
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -2290,7 +2290,7 @@ static const struct pid_entry tgid_base_stuff[] = {
> DIR("fd", S_IRUSR|S_IXUSR, fd),
> DIR("fdinfo", S_IRUSR|S_IXUSR, fdinfo),
> #ifdef CONFIG_NET
> - DIR("net", S_IRUGO|S_IXUSR, net),
> + DIR("net", S_IRUGO|S_IXUGO, net),
> #endif
> REG("environ", S_IRUSR, environ),
> INF("auxv", S_IRUSR, pid_auxv),

2008-03-20 22:27:40

by David Miller

[permalink] [raw]
Subject: Re: Fix permissions of /proc/net

From: Pavel Emelyanov <[email protected]>
Date: Thu, 20 Mar 2008 10:56:31 +0300

> Andre Noll wrote:
> > Signed-off-by: Andre Noll <[email protected]>
>
> Acked-by: Pavel Emelyanov <[email protected]>

Applied, thanks everyone.