From: Michael Opdenacker <[email protected]>
Document the compatible strings for the Milk-V Duo S board[1] which uses
the SOPHGO SG2000 SoC, compatible with the CV1812H SoC[2].
Link: https://milkv.io/duo-s [1]
Link: https://en.sophgo.com/product/introduce/cv181xH.html [2]
Signed-off-by: Michael Opdenacker <[email protected]>
---
Documentation/devicetree/bindings/riscv/sophgo.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
index 9bc813dad098..79546aa21021 100644
--- a/Documentation/devicetree/bindings/riscv/sophgo.yaml
+++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
@@ -24,6 +24,7 @@ properties:
- const: sophgo,cv1800b
- items:
- enum:
+ - milkv,duo-s
- sophgo,huashan-pi
- const: sophgo,cv1812h
- items:
--
2.34.1
On 21/04/2024 07:57, [email protected] wrote:
> From: Michael Opdenacker <[email protected]>
>
> Document the compatible strings for the Milk-V Duo S board[1] which uses
> the SOPHGO SG2000 SoC, compatible with the CV1812H SoC[2].
>
> Link: https://milkv.io/duo-s [1]
> Link: https://en.sophgo.com/product/introduce/cv181xH.html [2]
>
> Signed-off-by: Michael Opdenacker <[email protected]>
> ---
Where is the changelog? It's v6!
> Documentation/devicetree/bindings/riscv/sophgo.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> index 9bc813dad098..79546aa21021 100644
> --- a/Documentation/devicetree/bindings/riscv/sophgo.yaml
> +++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> @@ -24,6 +24,7 @@ properties:
> - const: sophgo,cv1800b
> - items:
> - enum:
> + - milkv,duo-s
? It was duo... and duos... now weirdly duo-s without explanation.
> - sophgo,huashan-pi
> - const: sophgo,cv1812h
It was CV1800 before... and you were asked for SoC compatible.
Please reach to your Bootlin folks to explain you how to send new
versions of patchsets and how to use compatibles.
Best regards,
Krzysztof
Hi Krzysztof
On 4/21/24 at 16:12, Krzysztof Kozlowski wrote:
> On 21/04/2024 07:57, [email protected] wrote:
>> From: Michael Opdenacker <[email protected]>
>>
>> Document the compatible strings for the Milk-V Duo S board[1] which uses
>> the SOPHGO SG2000 SoC, compatible with the CV1812H SoC[2].
>>
>> Link: https://milkv.io/duo-s [1]
>> Link: https://en.sophgo.com/product/introduce/cv181xH.html [2]
>>
>> Signed-off-by: Michael Opdenacker <[email protected]>
>> ---
> Where is the changelog? It's v6!
Oops, it was in my cover letter
(https://lore.kernel.org/linux-riscv/[email protected]/T/#t),
which you didn't get because of get-maintainer.pl. As the recipients are
patch dependent, am I supposed to describe the changes in all patches
and not only in the cover letter?
Cheers
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
On 21/04/2024 20:55, Michael Opdenacker wrote:
> Hi Krzysztof
>
> On 4/21/24 at 16:12, Krzysztof Kozlowski wrote:
>> On 21/04/2024 07:57, [email protected] wrote:
>>> From: Michael Opdenacker <[email protected]>
>>>
>>> Document the compatible strings for the Milk-V Duo S board[1] which uses
>>> the SOPHGO SG2000 SoC, compatible with the CV1812H SoC[2].
>>>
>>> Link: https://milkv.io/duo-s [1]
>>> Link: https://en.sophgo.com/product/introduce/cv181xH.html [2]
>>>
>>> Signed-off-by: Michael Opdenacker <[email protected]>
>>> ---
>> Where is the changelog? It's v6!
>
> Oops, it was in my cover letter
> (https://lore.kernel.org/linux-riscv/[email protected]/T/#t),
> which you didn't get because of get-maintainer.pl. As the recipients are
> patch dependent, am I supposed to describe the changes in all patches
> and not only in the cover letter?
If you do not send the changelog to everyone, then yes, please describe
respective changes in each patch.
It's your choice, but if you decide not to send cover letter to some
folks, then *it does not exist* for such folks.
Best regards,
Krzysztof
On 4/22/24 at 06:24, Krzysztof Kozlowski wrote:
> On 21/04/2024 20:55, Michael Opdenacker wrote:
>> Hi Krzysztof
>>
>> On 4/21/24 at 16:12, Krzysztof Kozlowski wrote:
>>> On 21/04/2024 07:57, [email protected] wrote:
>>>> From: Michael Opdenacker <[email protected]>
>>>>
>>>> Document the compatible strings for the Milk-V Duo S board[1] which uses
>>>> the SOPHGO SG2000 SoC, compatible with the CV1812H SoC[2].
>>>>
>>>> Link: https://milkv.io/duo-s [1]
>>>> Link: https://en.sophgo.com/product/introduce/cv181xH.html [2]
>>>>
>>>> Signed-off-by: Michael Opdenacker <[email protected]>
>>>> ---
>>> Where is the changelog? It's v6!
>> Oops, it was in my cover letter
>> (https://lore.kernel.org/linux-riscv/[email protected]/T/#t),
>> which you didn't get because of get-maintainer.pl. As the recipients are
>> patch dependent, am I supposed to describe the changes in all patches
>> and not only in the cover letter?
> If you do not send the changelog to everyone, then yes, please describe
> respective changes in each patch.
Ok, will do, thanks!
>
> It's your choice, but if you decide not to send cover letter to some
> folks, then *it does not exist* for such folks.
Well, actually, I shouldn't have let get-maintainer.pl decide for me. Is
there a way to send the cover-letter to the union of people who will
receive the individual patches?
Cheers
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Hi Michael,
On 4/22/24 9:23 AM, Michael Opdenacker wrote:
>
> On 4/22/24 at 06:24, Krzysztof Kozlowski wrote:
>> On 21/04/2024 20:55, Michael Opdenacker wrote:
>>> Hi Krzysztof
>>>
>>> On 4/21/24 at 16:12, Krzysztof Kozlowski wrote:
>>>> On 21/04/2024 07:57, [email protected] wrote:
>>>>> From: Michael Opdenacker <[email protected]>
>>>>>
>>>>> Document the compatible strings for the Milk-V Duo S board[1] which
>>>>> uses
>>>>> the SOPHGO SG2000 SoC, compatible with the CV1812H SoC[2].
>>>>>
>>>>> Link: https://milkv.io/duo-s [1]
>>>>> Link: https://en.sophgo.com/product/introduce/cv181xH.html [2]
>>>>>
>>>>> Signed-off-by: Michael Opdenacker <[email protected]>
>>>>> ---
>>>> Where is the changelog? It's v6!
>>> Oops, it was in my cover letter
>>> (https://lore.kernel.org/linux-riscv/[email protected]/T/#t),
>>> which you didn't get because of get-maintainer.pl. As the recipients are
>>> patch dependent, am I supposed to describe the changes in all patches
>>> and not only in the cover letter?
>> If you do not send the changelog to everyone, then yes, please describe
>> respective changes in each patch.
>
> Ok, will do, thanks!
>
>>
>> It's your choice, but if you decide not to send cover letter to some
>> folks, then *it does not exist* for such folks.
>
> Well, actually, I shouldn't have let get-maintainer.pl decide for me. Is
> there a way to send the cover-letter to the union of people who will
> receive the individual patches?
You may call get-maintainer.pl once for all the patches in the series
(e.g. use a glob pattern to select all needed files) and then manually
edit the cover letter to provide the 'To:' and 'Cc:' fields.
Additionally, you could use '--to-cover --cc-cover' arguments passed to
'git send-email' so that all those recipients will receive all patches.
Alternatively, you may try the b4 utility [1], which is able to automate
most of the manual steps.
Hope this helps!
Regards,
Cristian
[1]: https://b4.docs.kernel.org/en/latest/contributor/prep.html