2020-10-24 17:57:52

by Emilio López

[permalink] [raw]
Subject: Re: [linux-sunxi] [PATCH 03/10] ARM: dts: sun7i: cubietruck: Enable RGMII RX/TX delay on Ethernet PHY

El 24/10/20 a las 13:25, Chen-Yu Tsai escribió:
> From: Chen-Yu Tsai <[email protected]>
>
> The Ethernet PHY on the Cubietruck has the RX and TX delays
> enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins.
>
> Fix the phy-mode description to correct reflect this so that the
> implementation doesn't reconfigure the delays incorrectly. This
> happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e
> rx/tx delay config").
>
> Fixes: 67073d97672d ("ARM: dts: sun7i: cubietruck: Enable the GMAC")
> Signed-off-by: Chen-Yu Tsai <[email protected]>
> ---
> arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> index 8c8dee6ea461..9109ca0919ad 100644
> --- a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> @@ -151,7 +151,7 @@ &gmac {
> pinctrl-names = "default";
> pinctrl-0 = <&gmac_rgmii_pins>;
> phy-handle = <&phy1>;
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-id";
> status = "okay";
> };
>
>

I upgraded kernels yesterday and saw that networking had stopped
working. I can confirm that this patch fixes the problem and restores
connectivity on my Cubietruck. I also verified the information with the
schematics, and it looks alright to me :)

Reviewed-by: Emilio López <[email protected]>
Tested-by: Emilio López <[email protected]>

Thanks!
Emilio