2021-12-02 08:39:36

by Jiapeng Chong

Subject: [PATCH] media: i2c: Fix inconsistent indenting

Eliminate the follow smatch warning:

drivers/media/i2c/ov8865.c:2841 ov8865_get_selection() warn:
inconsistent indenting.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/media/i2c/ov8865.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
index ebdb20d..09ba13f 100644
--- a/drivers/media/i2c/ov8865.c
+++ b/drivers/media/i2c/ov8865.c
@@ -2836,8 +2836,7 @@ static int ov8865_get_selection(struct v4l2_subdev *subdev,
switch (sel->target) {
case V4L2_SEL_TGT_CROP:
mutex_lock(&sensor->mutex);
- __ov8865_get_pad_crop(sensor, state, sel->pad,
- sel->which, &sel->r);
+ __ov8865_get_pad_crop(sensor, state, sel->pad, sel->which, &sel->r);
mutex_unlock(&sensor->mutex);
break;
case V4L2_SEL_TGT_NATIVE_SIZE:
--
1.8.3.1

2021-12-02 09:48:05

by Daniel Scally

Subject: Re: [PATCH] media: i2c: Fix inconsistent indenting

Hi Jiapeng


Thanks for catching that

On 02/12/2021 08:39, Jiapeng Chong wrote:
> Eliminate the follow smatch warning:
>
> drivers/media/i2c/ov8865.c:2841 ov8865_get_selection() warn:
> inconsistent indenting.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>


Reviewed-by: Daniel Scally <[email protected]>

> ---
> drivers/media/i2c/ov8865.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
> index ebdb20d..09ba13f 100644
> --- a/drivers/media/i2c/ov8865.c
> +++ b/drivers/media/i2c/ov8865.c
> @@ -2836,8 +2836,7 @@ static int ov8865_get_selection(struct v4l2_subdev *subdev,
> switch (sel->target) {
> case V4L2_SEL_TGT_CROP:
> mutex_lock(&sensor->mutex);
> - __ov8865_get_pad_crop(sensor, state, sel->pad,
> - sel->which, &sel->r);
> + __ov8865_get_pad_crop(sensor, state, sel->pad, sel->which, &sel->r);
> mutex_unlock(&sensor->mutex);
> break;
> case V4L2_SEL_TGT_NATIVE_SIZE: