2022-02-09 23:53:01

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the amdgpu tree

Hi all,

In commit

41bea173d9b2 ("drm/amd/pm: drm/amd/pm: disable GetPptLimit message in sriov mode")

Fixes tag

Fixes: f3527a6483fbcc ("drm/amd/pm: Enable sysfs required by rocm-smi toolfor One VF mode")

has these problem(s):

- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2022-03-03 00:10:27

by Luben Tuikov

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the amdgpu tree

In our local branch it is:

60862e45da3b5a drm/amd/display: Don't fill up the logs
...
Fixes: 5898243ba7acdb ("drm/amd/display: Add dsc pre-validation in atomic check")

Which exists:

5898243ba7acdb drm/amd/display: Add dsc pre-validation in atomic check

So maybe something happened in merging, etc.

Regards,
Luben

On 2022-03-02 15:57, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> d15628d483a5 ("drm/amd/display: Don't fill up the logs")
>
> Fixes tag
>
> Fixes: 5898243ba7acdb ("drm/amd/display: Add dsc pre-validation in atomic check")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 17ce8a6907f7 ("drm/amd/display: Add dsc pre-validation in atomic check")
>

Regards,
--
Luben

2022-03-03 00:35:13

by Alex Deucher

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the amdgpu tree

On Wed, Mar 2, 2022 at 5:11 PM Luben Tuikov <[email protected]> wrote:
>
> In our local branch it is:
>
> 60862e45da3b5a drm/amd/display: Don't fill up the logs
> ...
> Fixes: 5898243ba7acdb ("drm/amd/display: Add dsc pre-validation in atomic check")
>
> Which exists:
>
> 5898243ba7acdb drm/amd/display: Add dsc pre-validation in atomic check
>
> So maybe something happened in merging, etc.

That's the commit in our development branch, but that doesn't directly
correspond to the -next branch. I've fixed it up and pushed a new
-next branch.

Alex

>
> Regards,
> Luben
>
> On 2022-03-02 15:57, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> > d15628d483a5 ("drm/amd/display: Don't fill up the logs")
> >
> > Fixes tag
> >
> > Fixes: 5898243ba7acdb ("drm/amd/display: Add dsc pre-validation in atomic check")
> >
> > has these problem(s):
> >
> > - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: 17ce8a6907f7 ("drm/amd/display: Add dsc pre-validation in atomic check")
> >
>
> Regards,
> --
> Luben