2021-06-02 06:48:10

by Zheng Yongjun

[permalink] [raw]
Subject: [PATCH net-next] batman-adv: Fix spelling mistakes

Fix some spelling mistakes in comments:
containg ==> containing
dont ==> don't
datas ==> data
brodcast ==> broadcast

Signed-off-by: Zheng Yongjun <[email protected]>
---
net/batman-adv/bridge_loop_avoidance.c | 4 ++--
net/batman-adv/hard-interface.c | 2 +-
net/batman-adv/hash.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/batman-adv/bridge_loop_avoidance.c b/net/batman-adv/bridge_loop_avoidance.c
index 7dc133cfc363..63d42dcc9324 100644
--- a/net/batman-adv/bridge_loop_avoidance.c
+++ b/net/batman-adv/bridge_loop_avoidance.c
@@ -395,7 +395,7 @@ static void batadv_bla_send_claim(struct batadv_priv *bat_priv, u8 *mac,
break;
case BATADV_CLAIM_TYPE_ANNOUNCE:
/* announcement frame
- * set HW SRC to the special mac containg the crc
+ * set HW SRC to the special mac containing the crc
*/
ether_addr_copy(hw_src, mac);
batadv_dbg(BATADV_DBG_BLA, bat_priv,
@@ -1040,7 +1040,7 @@ static int batadv_check_claim_group(struct batadv_priv *bat_priv,
/* lets see if this originator is in our mesh */
orig_node = batadv_orig_hash_find(bat_priv, backbone_addr);

- /* dont accept claims from gateways which are not in
+ /* don't accept claims from gateways which are not in
* the same mesh or group.
*/
if (!orig_node)
diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c
index 4a6a25d551a8..b99f64f483fc 100644
--- a/net/batman-adv/hard-interface.c
+++ b/net/batman-adv/hard-interface.c
@@ -403,7 +403,7 @@ int batadv_hardif_no_broadcast(struct batadv_hard_iface *if_outgoing,
goto out;
}

- /* >1 neighbors -> (re)brodcast */
+ /* >1 neighbors -> (re)broadcast */
if (rcu_dereference(hlist_next_rcu(first)))
goto out;

diff --git a/net/batman-adv/hash.h b/net/batman-adv/hash.h
index 46696759f194..fb251c385a1b 100644
--- a/net/batman-adv/hash.h
+++ b/net/batman-adv/hash.h
@@ -18,7 +18,7 @@
#include <linux/stddef.h>
#include <linux/types.h>

-/* callback to a compare function. should compare 2 element datas for their
+/* callback to a compare function. should compare 2 element data for their
* keys
*
* Return: true if same and false if not same
--
2.25.1


2021-06-02 08:52:56

by Sven Eckelmann

[permalink] [raw]
Subject: Re: [PATCH net-next] batman-adv: Fix spelling mistakes

On Wednesday, 2 June 2021 08:56:03 CEST Zheng Yongjun wrote:
> Fix some spelling mistakes in comments:
> containg ==> containing
> dont ==> don't
> datas ==> data
> brodcast ==> broadcast
>
> Signed-off-by: Zheng Yongjun <[email protected]>
> ---
> net/batman-adv/bridge_loop_avoidance.c | 4 ++--
> net/batman-adv/hard-interface.c | 2 +-
> net/batman-adv/hash.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)


You forgot to send it to the B.A.T.M.A.N. mailing list. And it therefore
didn't appear in our patchwork. And you send stuff from the future - which is
rather odd.

Applied anyway.

Thanks,
Sven


Attachments:
signature.asc (849.00 B)
This is a digitally signed message part.

2021-06-02 08:53:21

by Zheng Yongjun

[permalink] [raw]
Subject: 答复: [PATCH net-next] batman-adv: Fix spelli ng mistakes

Thanks for your suggest :)
In fact, I send patch through the python script made by myself.

When I use command" ./scripts/get_maintainer.pl 0001-batman-adv-Fix-spelling-mistakes.patch", the information is:
```
Marek Lindner <[email protected]> (maintainer:BATMAN ADVANCED)
Simon Wunderlich <[email protected]> (maintainer:BATMAN ADVANCED)
Antonio Quartulli <[email protected]> (maintainer:BATMAN ADVANCED)
Sven Eckelmann <[email protected]> (maintainer:BATMAN ADVANCED)
"David S. Miller" <[email protected]> (maintainer:NETWORKING [GENERAL])
Jakub Kicinski <[email protected]> (maintainer:NETWORKING [GENERAL])
[email protected] (moderated list:BATMAN ADVANCED)
[email protected] (open list:NETWORKING [GENERAL])
[email protected] (open list)
```

My send patch script forgot to deal with line like this(forgot deal with key word moderated list): " [email protected] (moderated list:BATMAN ADVANCED)"
Therefore I forgot to send it to the B.A.T.M.A.N. mailing list.

I will fix this, thank you for your suggest :)

-----?ʼ?ԭ??-----
??????: Sven Eckelmann [mailto:[email protected]]
????ʱ??: 2021??6??2?? 14:47
?ռ???: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; zhengyongjun <[email protected]>; [email protected]
????: Re: [PATCH net-next] batman-adv: Fix spelling mistakes

On Wednesday, 2 June 2021 08:56:03 CEST Zheng Yongjun wrote:
> Fix some spelling mistakes in comments:
> containg ==> containing
> dont ==> don't
> datas ==> data
> brodcast ==> broadcast
>
> Signed-off-by: Zheng Yongjun <[email protected]>
> ---
> net/batman-adv/bridge_loop_avoidance.c | 4 ++--
> net/batman-adv/hard-interface.c | 2 +-
> net/batman-adv/hash.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)


You forgot to send it to the B.A.T.M.A.N. mailing list. And it therefore didn't appear in our patchwork. And you send stuff from the future - which is rather odd.

Applied anyway.

Thanks,
Sven