Hi Tomi,
Thank you for the patches!
On 09/11/23 13:07, Tomi Valkeinen wrote:
> While working on the TI BSP kernel, adding bootload splash screen
> support, I noticed some issues with the driver and opportunities for
> cleanups and improvements.
>
> Tomi
>
> Signed-off-by: Tomi Valkeinen <[email protected]>
> ---
> Changes in v2:
> - Add missing pm_runtime_dont_use_autosuspend() in error path
> - Add simple manual "reset" for K2G
> - Leave tidss->dispc NULL if dispc_init fails
> - Add Fixes tags
> - Drop "drm/tidss: Add dispc_is_idle()"
> - Add "drm/tidss: Use DRM_PLANE_COMMIT_ACTIVE_ONLY"
> - Link to v1: https://lore.kernel.org/r/[email protected]
>
> ---
> Tomi Valkeinen (11):
> drm/tidss: Use pm_runtime_resume_and_get()
> drm/tidss: Use PM autosuspend
> drm/tidss: Drop useless variable init
> drm/tidss: Move reset to the end of dispc_init()
> drm/tidss: Return error value from from softreset
> drm/tidss: Check for K2G in in dispc_softreset()
> drm/tidss: Add simple K2G manual reset
> drm/tidss: Fix dss reset
> drm/tidss: IRQ code cleanup
> drm/tidss: Fix atomic_flush check
> drm/tidss: Use DRM_PLANE_COMMIT_ACTIVE_ONLY
For the series,
Reviewed-by: Aradhya Bhatia <[email protected]>
Regards
Aradhya
>
> drivers/gpu/drm/tidss/tidss_crtc.c | 12 ++----
> drivers/gpu/drm/tidss/tidss_dispc.c | 79 +++++++++++++++++++++++++++++++++----
> drivers/gpu/drm/tidss/tidss_drv.c | 15 +++++--
> drivers/gpu/drm/tidss/tidss_irq.c | 54 ++++---------------------
> drivers/gpu/drm/tidss/tidss_kms.c | 2 +-
> 5 files changed, 97 insertions(+), 65 deletions(-)
> ---
> base-commit: 9d7c8c066916f231ca0ed4e4fce6c4b58ca3e451
> change-id: 20231030-tidss-probe-854b1098c3af
>
> Best regards,