2023-06-16 14:17:27

by Geert Uytterhoeven

Subject: [PATCH] drm/atomic-helper: Update reference to drm_crtc_force_disable_all()

drm_crtc_force_disable_all() was renamed to
drm_helper_force_disable_all(), but one reference was not updated.

Fixes: c2d88e06bcb98540 ("drm: Move the legacy kms disable_all helper to crtc helpers")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/gpu/drm/drm_atomic_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index 41b8066f61fff4be..292e38eb621806a0 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -3332,7 +3332,7 @@ EXPORT_SYMBOL(drm_atomic_helper_disable_all);
* that also takes a snapshot of the modeset state to be restored on resume.
*
* This is just a convenience wrapper around drm_atomic_helper_disable_all(),
- * and it is the atomic version of drm_crtc_force_disable_all().
+ * and it is the atomic version of drm_helper_force_disable_all().
*/
void drm_atomic_helper_shutdown(struct drm_device *dev)
{
--
2.34.1

2023-06-16 16:33:40

by Sui Jingfeng

Subject: Re: drm/atomic-helper: Update reference to drm_crtc_force_disable_all()

Hi,


Nice patch!


By the way, thomas also fix a bug[1] by calling
drm_helper_force_disable_all() function

So this function seems useful. It deserved learn for a while. :-)


[1] https://patchwork.freedesktop.org/patch/541906/?series=119144&rev=1


On 2023/6/16 21:54, Geert Uytterhoeven wrote:
> drm_crtc_force_disable_all() was renamed to
> drm_helper_force_disable_all(), but one reference was not updated.
>
> Fixes: c2d88e06bcb98540 ("drm: Move the legacy kms disable_all helper to crtc helpers")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Reviewed-by Sui Jingfeng <[email protected]>

> ---
> drivers/gpu/drm/drm_atomic_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> index 41b8066f61fff4be..292e38eb621806a0 100644
> --- a/drivers/gpu/drm/drm_atomic_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_helper.c
> @@ -3332,7 +3332,7 @@ EXPORT_SYMBOL(drm_atomic_helper_disable_all);
> * that also takes a snapshot of the modeset state to be restored on resume.
> *
> * This is just a convenience wrapper around drm_atomic_helper_disable_all(),
> - * and it is the atomic version of drm_crtc_force_disable_all().
> + * and it is the atomic version of drm_helper_force_disable_all().
> */
> void drm_atomic_helper_shutdown(struct drm_device *dev)
> {

--
Jingfeng

2023-06-16 16:34:03

by Sui Jingfeng

Subject: Re: drm/atomic-helper: Update reference to drm_crtc_force_disable_all()

On 2023/6/16 21:54, Geert Uytterhoeven wrote:
> drm_crtc_force_disable_all() was renamed to
> drm_helper_force_disable_all(), but one reference was not updated.
>
> Fixes: c2d88e06bcb98540 ("drm: Move the legacy kms disable_all helper to crtc helpers")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
Reviewed-by: Sui Jingfeng <[email protected]>
> ---
> drivers/gpu/drm/drm_atomic_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> index 41b8066f61fff4be..292e38eb621806a0 100644
> --- a/drivers/gpu/drm/drm_atomic_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_helper.c
> @@ -3332,7 +3332,7 @@ EXPORT_SYMBOL(drm_atomic_helper_disable_all);
> * that also takes a snapshot of the modeset state to be restored on resume.
> *
> * This is just a convenience wrapper around drm_atomic_helper_disable_all(),
> - * and it is the atomic version of drm_crtc_force_disable_all().
> + * and it is the atomic version of drm_helper_force_disable_all().
> */
> void drm_atomic_helper_shutdown(struct drm_device *dev)
> {

--
Jingfeng