by Dan Williams

[permalink] [raw]

Subject: Re: iwl4965 oops in 2.6.26-rc5 x86_64

On Fri, 2008-06-06 at 18:57 +0300, Thomas Backlund wrote:
> Dan Williams skrev:
> > On Fri, 2008-06-06 at 18:12 +0300, Tomas Winkler wrote:
> >> On Fri, Jun 6, 2008 at 5:51 PM, Thomas Backlund <[email protected]> wrote:
> >>> Tomas Winkler skrev:
> >>>> On Fri, Jun 6, 2008 at 3:33 PM, Thomas Backlund <[email protected]> wrote:
> >>>>> Thomas Backlund skrev:
> >>>>>> Tomas Winkler skrev:
> >>>>>>> On Fri, Jun 6, 2008 at 3:44 AM, Ian Schram <[email protected]> wrote:
> >>>>>>>> Isn't this the Oops Joonwoo Park wanted to patch with
> >>>>>>>>
> >>>>>>>> "[PATCH] iwlwifi: fix oops on wep key insertion" 27/5/2008
> >>>>>>>>
> >>>>>>>> invalid length of webkey that would/should be handled in mac80211?
> >>>>>>>>
> >>>>>>>> ian
> >>>>>>> Yes, it looks like.
> >>>>>> Ummm, what has a wep key to do with me trying to access a WPA2-Personal
> >>>>>> encrypted net ?
> >>>> Not sure yet, but mac is trying to assign default/static wep key.
> >>>>
> >>>> :iwlcore:iwl_send_static_wepkey_cmd+0xcb/0xd5
> >>>> :iwlcore:iwl_set_default_wep_key+0xa2/0xbc
> >>>>
> >>>> Try to set the encryption explicitly
> >>>> network={
> >>>> psk="*************************"
> >>>> scan_ssid=1
> >>>> ssid="dlink"
> >>>> pairwise=CCMP
> >>>> group=CCMP
> >>>> }
> >>>>
> >>>>
> >>> That didn't help at all...
> >>>
> >>> What's more it prevented the wifi to work on 2.6.24.7 so I had to remove the
> >>> lines again...
> >>>
> >> So what's your AP configuration TKIP?
> >
> > Yeah, the supplicant log he posted clearly shows that the GTK is TKIP.
> >
> > > 1212763152.516781: wpa_driver_wext_set_key: alg=2 key_idx=1 set_tx=0 seq_len=6 key_len=32
> >> 1212763152.516790: WPA: Key negotiation completed with 00:xx:xx:xx:xx:xx [PTK=CCMP GTK=TKIP]
> >
>
> The AP is actually set for TKIP+AES
>
> BTW, is that better or worse than a clean AES ?
> I'm reading up on it, but I get a lot of conflicting info...

It's less secure than straight AES.

WEP < TKIP < AES/CCMP

Dan

> > Dan
> >
> >> Second try also with sw decryption:
> >>
> >> in /etc/modprobe.conf
> >> options iwl4965 swcrypto=1
> >>
> >>
> >> Tomas
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> >> the body of a message to [email protected]
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
> Thomas

2008-06-06 21:44:36

by Thomas Backlund

[permalink] [raw]

Subject: Re: iwl4965 oops in 2.6.26-rc5 x86_64

Tomas Winkler skrev:
> On Fri, Jun 6, 2008 at 5:51 PM, Thomas Backlund <[email protected]> wrote:
>> Tomas Winkler skrev:
>>> On Fri, Jun 6, 2008 at 3:33 PM, Thomas Backlund <[email protected]> wrote:
>>>> Thomas Backlund skrev:
>>>>> Tomas Winkler skrev:
>>>>>> On Fri, Jun 6, 2008 at 3:44 AM, Ian Schram <[email protected]> wrote:
>>>>>>> Isn't this the Oops Joonwoo Park wanted to patch with
>>>>>>>
>>>>>>> "[PATCH] iwlwifi: fix oops on wep key insertion" 27/5/2008
>>>>>>>
>>>>>>> invalid length of webkey that would/should be handled in mac80211?
>>>>>>>
>>>>>>> ian
>>>>>> Yes, it looks like.
>>>>> Ummm, what has a wep key to do with me trying to access a WPA2-Personal
>>>>> encrypted net ?
>>> Not sure yet, but mac is trying to assign default/static wep key.
>>>
>>> :iwlcore:iwl_send_static_wepkey_cmd+0xcb/0xd5
>>> :iwlcore:iwl_set_default_wep_key+0xa2/0xbc
>>>
>>> Try to set the encryption explicitly
>>> network={
>>> psk="*************************"
>>> scan_ssid=1
>>> ssid="dlink"
>>> pairwise=CCMP
>>> group=CCMP
>>> }
>>>
>>>
>> That didn't help at all.
>>
>> What's more it prevented the wifi to work on 2.6.24.7 so I had to remove the
>> lines again...
>>
> So what's your AP configuration TKIP?
>

I've switched to clean WPA2-AES on the AP, but it does not do any
difference... I still get the oops...

> Second try also with sw decryption:
>
> in /etc/modprobe.conf
> options iwl4965 swcrypto=1
>

That works.
I now run a clean 2.6.26-rc5

I also tried to bisect between 2.6.25 and 2.6.26-rc1 and ended up with:

[root@5720g linux-2.6]# git bisect good
8318d78a44d49ac1edf2bdec7299de3617c4232e is first bad commit
commit 8318d78a44d49ac1edf2bdec7299de3617c4232e
Author: Johannes Berg <[email protected]>
Date: Thu Jan 24 19:38:38 2008 +0100

cfg80211 API for channels/bitrates, mac80211 and driver conversion

Any more I can provide to help finding the bug ?
--
Thomas