remove unused function aio_run_iocbs()
Signed-off-by: Nikanth Karthikesan <[email protected]>
---
diff --git a/fs/aio.c b/fs/aio.c
index 0fb3117..e27f611 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -797,26 +797,6 @@ static void aio_queue_work(struct kioctx * ctx)
queue_delayed_work(aio_wq, &ctx->wq, timeout);
}
-
-/*
- * aio_run_iocbs:
- * Process all pending retries queued on the ioctx
- * run list.
- * Assumes it is operating within the aio issuer's mm
- * context.
- */
-static inline void aio_run_iocbs(struct kioctx *ctx)
-{
- int requeue;
-
- spin_lock_irq(&ctx->ctx_lock);
-
- requeue = __aio_run_iocbs(ctx);
- spin_unlock_irq(&ctx->ctx_lock);
- if (requeue)
- aio_queue_work(ctx);
-}
-
/*
* just like aio_run_iocbs, but keeps running them until
* the list stays empty
Nikanth Karthikesan <[email protected]> writes:
> remove unused function aio_run_iocbs()
Seems like it's time to just get rid of it. See:
http://ussg.iu.edu/hypermail/linux/kernel/0608.0/0048.html
for an explanation of why it's still there.
Cheers,
Jeff
Jeff Moyer wrote:
> Nikanth Karthikesan <[email protected]> writes:
>
>> remove unused function aio_run_iocbs()
>
> Seems like it's time to just get rid of it. See:
> http://ussg.iu.edu/hypermail/linux/kernel/0608.0/0048.html
> for an explanation of why it's still there.
Yeah, I'm still of the opinion that the cost of having to resurrect it
if it's needed again isn't significant enough to keep it in the tree
without callers.
- z
On Tue, Jul 01, 2008 at 01:55:50PM +0530, Nikanth Karthikesan wrote:
> Can't this function be kept as part of the out-of-tree patch itself? Or is it
> a module that requires this symbol? I do not see a EXPORT_SYMBOL*() for this,
> so it cannot be a module depending on this func!?
Yes. There's very very few reason to keep unused functions around,
and a patch that hasn't been merged forever is not one of those.
Please kill it.
On Monday 30 June 2008 23:10:50 Zach Brown wrote:
> Jeff Moyer wrote:
> > Nikanth Karthikesan <[email protected]> writes:
> >> remove unused function aio_run_iocbs()
> >
> > Seems like it's time to just get rid of it. See:
> > http://ussg.iu.edu/hypermail/linux/kernel/0608.0/0048.html
> > for an explanation of why it's still there.
>
> Yeah, I'm still of the opinion that the cost of having to resurrect it
> if it's needed again isn't significant enough to keep it in the tree
> without callers.
>
Can't this function be kept as part of the out-of-tree patch itself? Or is it
a module that requires this symbol? I do not see a EXPORT_SYMBOL*() for this,
so it cannot be a module depending on this func!?
Thanks
Nikanth Karthikesan