2008-07-08 01:37:19

by Hiroshi Shimamoto

Subject: [PATCH] softlockup: fix invalid proc_handler for softlockup_panic

From: Hiroshi Shimamoto <[email protected]>

The type of softlockup_panic is int, but the proc_handler is
proc_doulongvec_minmax(). This handler is for unsigned long.

This handler should be proc_dointvec_minmax().

Signed-off-by: Hiroshi Shimamoto <[email protected]>
---
kernel/sysctl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 683986d..5b8b4c1 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -757,7 +757,7 @@ static struct ctl_table kern_table[] = {
.data = &softlockup_panic,
.maxlen = sizeof(int),
.mode = 0644,
- .proc_handler = &proc_doulongvec_minmax,
+ .proc_handler = &proc_dointvec_minmax,
.strategy = &sysctl_intvec,
.extra1 = &zero,
.extra2 = &one,
--
1.5.4.1

2008-07-18 16:30:23

by Ingo Molnar

Subject: Re: [PATCH] softlockup: fix invalid proc_handler for softlockup_panic

* Hiroshi Shimamoto <[email protected]> wrote:

> From: Hiroshi Shimamoto <[email protected]>
>
> The type of softlockup_panic is int, but the proc_handler is
> proc_doulongvec_minmax(). This handler is for unsigned long.
>
> This handler should be proc_dointvec_minmax().

applied to tip/core/softlockup - thanks!

Ingo