2008-07-28 21:41:31

by Adrian Bunk

Subject: sh se7750_defconfig compile error

Commit ffb91ad2751723bcc9925cd38e37013e2169e256
(sh: Solution Enginge 7710/7712 SH-Ether support)
causes the following compile error with se7750_defconfig:

<-- snip -->

...
CC arch/sh/boards/se/770x/setup.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/sh/boards/se/770x/setup.c:134: error: 'PHY_ID' undeclared here (not in a function)
make[2]: *** [arch/sh/boards/se/770x/setup.o] Error 1

<-- snip -->

The patch did:
#if defined(CONFIG_CPU_SUBTYPE_SH7710)
# define PHY_ID 0x00
#elif defined(CONFIG_CPU_SUBTYPE_SH7712)
# define PHY_ID 0x01
#endif

But in this case we have CONFIG_CPU_SUBTYPE_SH7750.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2008-07-29 05:56:50

by Nobuhiro Iwamatsu

Subject: Re: sh se7750_defconfig compile error

Hi, Adrian.

Thank you for your check and report.

I will fix this soon.

Best regards,
Nobuhiro

Adrian Bunk wrote:
> Commit ffb91ad2751723bcc9925cd38e37013e2169e256
> (sh: Solution Enginge 7710/7712 SH-Ether support)
> causes the following compile error with se7750_defconfig:
>
> <-- snip -->
>
> ...
> CC arch/sh/boards/se/770x/setup.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/sh/boards/se/770x/setup.c:134: error: 'PHY_ID' undeclared here (not in a function)
> make[2]: *** [arch/sh/boards/se/770x/setup.o] Error 1
>
> <-- snip -->
>
> The patch did:
> #if defined(CONFIG_CPU_SUBTYPE_SH7710)
> # define PHY_ID 0x00
> #elif defined(CONFIG_CPU_SUBTYPE_SH7712)
> # define PHY_ID 0x01
> #endif
>
> But in this case we have CONFIG_CPU_SUBTYPE_SH7750.
>
> cu
> Adrian
>