[Previously sent with wrong subject line (2.6.26-rc1...) applicable
to post 2.6.26 series]
Missed most of the 26-git series, git6 first one tried and oops
showed in that one as well as those tried after. oops below.
--
Pete Clements
pnp: the driver 'cs4236_isapnp' has been registered
cs4236_isapnp 01:01.00: driver attached
cs4236_isapnp 01:01.02: driver attached
cs4236_isapnp 01:01.00: pnp_assign_resources, try dependent set 0
cs4236_isapnp 01:01.00: add dma 1 flags 0x40000028
cs4236_isapnp 01:01.00: add dma 3 flags 0x40000028
cs4236_isapnp 01:01.00: add irq 5 flags 0x40000001
cs4236_isapnp 01:01.00: add io 0x534-0x537 flags 0x40000001
cs4236_isapnp 01:01.00: add io 0x388-0x38b flags 0x40000001
cs4236_isapnp 01:01.00: add io 0x220-0x22f flags 0x40000001
cs4236_isapnp 01:01.00: pnp_assign_resources succeeded: current resources:
cs4236_isapnp 01:01.00: dma 1 flags 0x40000828
cs4236_isapnp 01:01.00: dma 1 flags 0x40000828 dma 3 flags 0x40000828
cs4236_isapnp 01:01.00: dma 1 flags 0x40000828 dma 3 flags 0x40000828 irq 5 flags 0x40000401
cs4236_isapnp 01:01.00: dma 1 flags 0x40000828 dma 3 flags 0x40000828 irq 5 flags 0x40000401 io 0x534-0x537 flags 0x40000101
cs4236_isapnp 01:01.00: dma 1 flags 0x40000828 dma 3 flags 0x40000828 irq 5 flags 0x40000401 io 0x534-0x537 flags 0x40000101 io 0x388-0x38b fla
------------[ cut here ]------------
WARNING: at lib/vsprintf.c:609 vsnprintf+0x6c7/0x6d0()
Modules linked in: snd_cs4236(+) snd_opl3_lib snd_seq_dummy snd_hwdep snd_cs4236_lib snd_mpu401_uart snd_seq_oss(+) snd_seq_midi snd_seq_midi_event snd_seq snd_rawmidi snd_seq_device snd_cs4231_lib snd_pcm_oss snd_mixer_oss snd_pcm snd_timer uhci_hcd snd i2c_piix4 usbcore soundcore sg snd_page_alloc 3c59x i2c_core mii
Pid: 1885, comm: modprobe Not tainted 2.6.27-rc1 #1
[<c011f621>] warn_on_slowpath+0x61/0xa0
[<c011a017>] __dequeue_entity+0x57/0xd0
[<c011684d>] update_curr+0x4d/0x70
[<c011a18d>] pick_next_task_fair+0x8d/0x100
[<c01e17b7>] string+0x27/0xc0
[<c01e1c09>] vsnprintf+0x3b9/0x6d0
[<c01e1177>] number+0x2a7/0x2b0
[<c01e17b7>] string+0x27/0xc0
[<c01e1f17>] vsnprintf+0x6c7/0x6d0
[<c01dc4c0>] idr_get_new_above_int+0x10/0x80
[<c0136601>] up+0x11/0x40
[<c011fe6e>] release_console_sem+0x19e/0x1d0
[<c01dc8d3>] idr_remove+0x173/0x1d0
[<c01a442d>] xlate_proc_name+0x3d/0xc0
[<c01e1fab>] snprintf+0x1b/0x20
[<c01fca09>] dbg_pnp_show_resources+0x129/0x220
[<c01fbc2e>] pnp_assign_resources+0x18e/0x850
[<c017f16d>] iput+0x1d/0x50
[<c01ac33a>] sysfs_addrm_finish+0x3a/0x1f0
[<c02e18ee>] klist_node_init+0x2e/0x50
[<c01fc347>] pnp_auto_config_dev+0x57/0xb0
[<c01f9dfe>] pnp_request_card_device+0xbe/0xf0
[<c01fc3bf>] pnp_activate_dev+0x1f/0x50
[<f88ce50c>] snd_cs423x_pnpc_detect+0x11f/0x3b4 [snd_cs4236]
[<c01f9c0a>] card_probe+0xea/0x170
[<c01f9d2e>] pnp_register_card_driver+0x9e/0xb0
[<f8839027>] alsa_card_cs423x_init+0x27/0x49 [snd_cs4236]
[<c0140d46>] sys_init_module+0x136/0x1920
[<c0124f50>] __request_region+0x0/0xd0
[<c0103026>] syscall_call+0x7/0xb
=======================
---[ end trace b28563869b69121a ]---
cs4236_isapnp 01:01.00: dma 1 flags 0x40000828 dma 3 flags 0x40000828 irq 5 flags 0x40000401 io 0x534-0x537 flags 0x40000101 io 0x388-0x38b fla
cs4236_isapnp 01:01.00: pnp_start_dev: current resources:
cs4236_isapnp 01:01.00: dma 1 flags 0x40000828
cs4236_isapnp 01:01.00: dma 1 flags 0x40000828 dma 3 flags 0x40000828
cs4236_isapnp 01:01.00: dma 1 flags 0x40000828 dma 3 flags 0x40000828 irq 5 flags 0x40000401
cs4236_isapnp 01:01.00: dma 1 flags 0x40000828 dma 3 flags 0x40000828 irq 5 flags 0x40000401 io 0x534-0x537 flags 0x40000101
cs4236_isapnp 01:01.00: dma 1 flags 0x40000828 dma 3 flags 0x40000828 irq 5 flags 0x40000401 io 0x534-0x537 flags 0x40000101 io 0x388-0x38b fla
cs4236_isapnp 01:01.00: dma 1 flags 0x40000828 dma 3 flags 0x40000828 irq 5 flags 0x40000401 io 0x534-0x537 flags 0x40000101 io 0x388-0x38b fla
cs4236_isapnp 01:01.00: set resources
cs4236_isapnp 01:01.00: set io 0 to 0x534
cs4236_isapnp 01:01.00: set io 1 to 0x388
cs4236_isapnp 01:01.00: set io 2 to 0x220
cs4236_isapnp 01:01.00: set irq 0 to 5
cs4236_isapnp 01:01.00: set dma 0 to 1
cs4236_isapnp 01:01.00: set dma 1 to 3
cs4236_isapnp 01:01.00: activated
cs4236_isapnp 01:01.02: pnp_assign_resources, try dependent set 0
cs4236_isapnp 01:01.02: add io 0xf00-0xf07 flags 0x40000001
cs4236_isapnp 01:01.02: pnp_assign_resources succeeded: current resources:
cs4236_isapnp 01:01.02: io 0xf00-0xf07 flags 0x40000101
cs4236_isapnp 01:01.02: pnp_start_dev: current resources:
cs4236_isapnp 01:01.02: io 0xf00-0xf07 flags 0x40000101
cs4236_isapnp 01:01.02: set resources
cs4236_isapnp 01:01.02: set io 0 to 0xf00
cs4236_isapnp 01:01.02: activated
>From clem Tue Jul 29 16:43:15 2008
Subject: KMail UPS
To: [email protected]
Date: Tue, 29 Jul 2008 16:43:15 -0400 (EDT)
X-Mailer: ELM [version 2.5 PL7]
Content-Length: 20
--
Pete Clements
--
Pete Clements
On 29-07-08 22:52, Pete Clements wrote:
> [Previously sent with wrong subject line (2.6.26-rc1...) applicable
> to post 2.6.26 series]
>
> Missed most of the 26-git series, git6 first one tried and oops
> showed in that one as well as those tried after. oops below.
http://marc.info/?l=linux-kernel&m=121736480005656&w=2
For now just adding a CC as I'm off to bed. Note -- snd-cs4236 has been
one of the most tested drivers with the new PNP code.
Rene.
On Tuesday 29 July 2008 6:02:46 pm Rene Herman wrote:
> On 29-07-08 22:52, Pete Clements wrote:
> > [Previously sent with wrong subject line (2.6.26-rc1...) applicable
> > to post 2.6.26 series]
> >
> > Missed most of the 26-git series, git6 first one tried and oops
> > showed in that one as well as those tried after. oops below.
>
> http://marc.info/?l=linux-kernel&m=121736480005656&w=2
>
> For now just adding a CC as I'm off to bed. Note -- snd-cs4236 has been
> one of the most tested drivers with the new PNP code.
Thanks very much for the report. Can I trouble you to test the
patch below and see whether it fixes the problem?
PNP: fix formatting of dbg_pnp_show_resources() output
From: Bjorn Helgaas <[email protected]>
Each resource should be printed on its own line, so start snprintf'ing
at the beginning of the buffer every time through the loop.
Signed-off-by: Bjorn Helgaas <[email protected]>
---
drivers/pnp/support.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/pnp/support.c b/drivers/pnp/support.c
index bbf78ef..57b775b 100644
--- a/drivers/pnp/support.c
+++ b/drivers/pnp/support.c
@@ -77,7 +77,7 @@ void dbg_pnp_show_resources(struct pnp_dev *dev, char *desc)
{
#ifdef DEBUG
char buf[128];
- int len = 0;
+ int len;
struct pnp_resource *pnp_res;
struct resource *res;
@@ -89,6 +89,7 @@ void dbg_pnp_show_resources(struct pnp_dev *dev, char *desc)
dev_dbg(&dev->dev, "%s: current resources:\n", desc);
list_for_each_entry(pnp_res, &dev->resources, list) {
res = &pnp_res->res;
+ len = 0;
len += snprintf(buf + len, sizeof(buf) - len, " %-3s ",
pnp_resource_type_name(res));
Quoting Bjorn Helgaas
> On Tuesday 29 July 2008 6:02:46 pm Rene Herman wrote:
> > On 29-07-08 22:52, Pete Clements wrote:
> > > [Previously sent with wrong subject line (2.6.26-rc1...) applicable
> > > to post 2.6.26 series]
> > >
> > > Missed most of the 26-git series, git6 first one tried and oops
> > > showed in that one as well as those tried after. oops below.
> >
>
> Thanks very much for the report. Can I trouble you to test the
> patch below and see whether it fixes the problem?
>
Patch clears the problem. Thanks.
--
Pete Clements
>
> PNP: fix formatting of dbg_pnp_show_resources() output
>
> From: Bjorn Helgaas <[email protected]>
>
> Each resource should be printed on its own line, so start snprintf'ing
> at the beginning of the buffer every time through the loop.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>
> ---
>
> drivers/pnp/support.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>
> diff --git a/drivers/pnp/support.c b/drivers/pnp/support.c
> index bbf78ef..57b775b 100644
> --- a/drivers/pnp/support.c
> +++ b/drivers/pnp/support.c
> @@ -77,7 +77,7 @@ void dbg_pnp_show_resources(struct pnp_dev *dev, char *desc)
> {
> #ifdef DEBUG
> char buf[128];
> - int len = 0;
> + int len;
> struct pnp_resource *pnp_res;
> struct resource *res;
>
> @@ -89,6 +89,7 @@ void dbg_pnp_show_resources(struct pnp_dev *dev, char *desc)
> dev_dbg(&dev->dev, "%s: current resources:\n", desc);
> list_for_each_entry(pnp_res, &dev->resources, list) {
> res = &pnp_res->res;
> + len = 0;
>
> len += snprintf(buf + len, sizeof(buf) - len, " %-3s ",
> pnp_resource_type_name(res));
>
On 30-07-08 05:59, Bjorn Helgaas wrote:
> PNP: fix formatting of dbg_pnp_show_resources() output
>
> From: Bjorn Helgaas <[email protected]>
>
> Each resource should be printed on its own line, so start snprintf'ing
> at the beginning of the buffer every time through the loop.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>
Good WARN_ON() that...
I was looking at why I hadn't seen this here even with the same hardware
when I _did_ see it here. Most definitely did not back when I was paying
attention -- although there seems to be little opportunity for that.
Just for my own education; did something recent happen to bring this on
or must this have been present always? Serious buglet it seems.
Rene
On Wednesday 30 July 2008 6:15:07 am Rene Herman wrote:
> On 30-07-08 05:59, Bjorn Helgaas wrote:
> > PNP: fix formatting of dbg_pnp_show_resources() output
> >
> > From: Bjorn Helgaas <[email protected]>
> >
> > Each resource should be printed on its own line, so start snprintf'ing
> > at the beginning of the buffer every time through the loop.
> >
> > Signed-off-by: Bjorn Helgaas <[email protected]>
>
> Good WARN_ON() that...
>
> I was looking at why I hadn't seen this here even with the same hardware
> when I _did_ see it here. Most definitely did not back when I was paying
> attention -- although there seems to be little opportunity for that.
>
> Just for my own education; did something recent happen to bring this on
> or must this have been present always? Serious buglet it seems.
That function used to printk the resource piece-meal -- first the
resource type, then the value, then the flags, etc. I made a late
change to snprintf everything into the buffer, then do a single
printk to keep everything atomic, and I didn't test it well enough.
Bjorn