2023-11-29 13:39:28

by Rafael J. Wysocki

Subject: [PATCH v3 0/2] thermal: trip: Rework thermal_zone_set_trip() and its callers

Hi Everyone,

This is the third iteration of

https://patchwork.kernel.org/project/linux-pm/patch/4892163.31r3eYUQgx@kreacher/

which fixes one issue found in the second iteration:

https://lore.kernel.org/linux-pm/6010559.lOV4Wx5bFT@kreacher/

Thanks!

2023-11-29 13:39:35

by Rafael J. Wysocki

Subject: [PATCH v3 1/2] thermal: trip: Drop a redundant check from thermal_zone_set_trip()

From: Rafael J. Wysocki <[email protected]>

After recent changes in the thermal framework, a trip points array is
required for registering a thermal zone that is not tripless, so the
tz->trips pointer in thermal_zone_set_trip() is never NULL and the
check involving it is redundant. Drop that check.

No functional impact.

Signed-off-by: Rafael J. Wysocki <[email protected]>
Reviewed-by: Lukasz Luba <[email protected]>
---

v2 -> v3: Add the tag from Lukasz

v1 -> v2: New patch

---
drivers/thermal/thermal_trip.c | 3 ---
1 file changed, 3 deletions(-)

Index: linux-pm/drivers/thermal/thermal_trip.c
===================================================================
--- linux-pm.orig/drivers/thermal/thermal_trip.c
+++ linux-pm/drivers/thermal/thermal_trip.c
@@ -153,9 +153,6 @@ int thermal_zone_set_trip(struct thermal
struct thermal_trip t;
int ret;

- if (!tz->ops->set_trip_temp && !tz->ops->set_trip_hyst && !tz->trips)
- return -EINVAL;
-
ret = __thermal_zone_get_trip(tz, trip_id, &t);
if (ret)
return ret;

2023-11-29 15:27:41

by Daniel Lezcano

Subject: Re: [PATCH v3 1/2] thermal: trip: Drop a redundant check from thermal_zone_set_trip()

On 29/11/2023 14:36, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <[email protected]>
>
> After recent changes in the thermal framework, a trip points array is
> required for registering a thermal zone that is not tripless, so the
> tz->trips pointer in thermal_zone_set_trip() is never NULL and the
> check involving it is redundant. Drop that check.
>
> No functional impact.
>
> Signed-off-by: Rafael J. Wysocki <[email protected]>
> Reviewed-by: Lukasz Luba <[email protected]>

Acked-by: Daniel Lezcano <[email protected]>

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2023-11-30 13:39:31

by Rafael J. Wysocki

Subject: Re: [PATCH v3 1/2] thermal: trip: Drop a redundant check from thermal_zone_set_trip()

On Wed, Nov 29, 2023 at 4:26 PM Daniel Lezcano
<[email protected]> wrote:
>
> On 29/11/2023 14:36, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <[email protected]>
> >
> > After recent changes in the thermal framework, a trip points array is
> > required for registering a thermal zone that is not tripless, so the
> > tz->trips pointer in thermal_zone_set_trip() is never NULL and the
> > check involving it is redundant. Drop that check.
> >
> > No functional impact.
> >
> > Signed-off-by: Rafael J. Wysocki <[email protected]>
> > Reviewed-by: Lukasz Luba <[email protected]>
>
> Acked-by: Daniel Lezcano <[email protected]>

Applied, thanks!