2008-08-05 22:53:21

by Robert P. J. Day

Subject: does an initcall level of "0s" actually exist?

from include/asm-generic/vmlinux.lds.h:

#define INITCALLS \
*(.initcallearly.init) \
VMLINUX_SYMBOL(__early_initcall_end) = .; \
*(.initcall0.init) \
*(.initcall0s.init) \
*(.initcall1.init) \
*(.initcall1s.init) \
... etc ...

but from include/linux/init.h:

#define pure_initcall(fn) __define_initcall("0",fn,0)

#define core_initcall(fn) __define_initcall("1",fn,1)
#define core_initcall_sync(fn) __define_initcall("1s",fn,1s)
#define postcore_initcall(fn) __define_initcall("2",fn,2)
#define postcore_initcall_sync(fn) __define_initcall("2s",fn,2s)

i don't see any initcalls of level "0s". in any event, might it not
be cleaner to have these files sync up? no big deal, of course. i'm
well aware that it doesn't break anything.

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================

2008-08-06 22:14:19

by Rene Herman

Subject: Re: does an initcall level of "0s" actually exist?

On 06-08-08 00:51, Robert P. J. Day wrote:

> from include/asm-generic/vmlinux.lds.h:
>
> #define INITCALLS \
> *(.initcallearly.init) \
> VMLINUX_SYMBOL(__early_initcall_end) = .; \
> *(.initcall0.init) \
> *(.initcall0s.init) \
> *(.initcall1.init) \
> *(.initcall1s.init) \
> ... etc ...
>
> but from include/linux/init.h:
>
> #define pure_initcall(fn) __define_initcall("0",fn,0)
>
> #define core_initcall(fn) __define_initcall("1",fn,1)
> #define core_initcall_sync(fn) __define_initcall("1s",fn,1s)
> #define postcore_initcall(fn) __define_initcall("2",fn,2)
> #define postcore_initcall_sync(fn) __define_initcall("2s",fn,2s)
>
> i don't see any initcalls of level "0s". in any event, might it not
> be cleaner to have these files sync up? no big deal, of course. i'm
> well aware that it doesn't break anything.

Last I heard, all sync levels were on their way out (Arjan).

Rene.

2008-08-06 22:21:39

by Robert P. J. Day

Subject: Re: does an initcall level of "0s" actually exist?

On Thu, 7 Aug 2008, Rene Herman wrote:

> On 06-08-08 00:51, Robert P. J. Day wrote:
>
> > from include/asm-generic/vmlinux.lds.h:
> >
> > #define INITCALLS \
> > *(.initcallearly.init) \
> > VMLINUX_SYMBOL(__early_initcall_end) = .; \
> > *(.initcall0.init) \
> > *(.initcall0s.init) \
> > *(.initcall1.init) \
> > *(.initcall1s.init) \
> > ... etc ...
> >
> > but from include/linux/init.h:
> >
> > #define pure_initcall(fn) __define_initcall("0",fn,0)
> >
> > #define core_initcall(fn) __define_initcall("1",fn,1)
> > #define core_initcall_sync(fn) __define_initcall("1s",fn,1s)
> > #define postcore_initcall(fn) __define_initcall("2",fn,2)
> > #define postcore_initcall_sync(fn) __define_initcall("2s",fn,2s)
> >
> > i don't see any initcalls of level "0s". in any event, might it not
> > be cleaner to have these files sync up? no big deal, of course. i'm
> > well aware that it doesn't break anything.
>
> Last I heard, all sync levels were on their way out (Arjan).

ah, i was unaware of that, thanks.

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================