2006-02-20 04:24:35

by Luke Yang

Subject: [PATCH] Fix undefined symbols for nommu architecture

Hi,

This is a patch to add or export some undefined symbols in nommu
architectures (mm/nommu.c). Based on latest mm-tree. Following
symbols are added: vmap, vunmap, randomize_va_space.

Signed-off-by: Luke Yang <[email protected]>

Index: git/linux-2.6/mm/nommu.c
===================================================================
--- git.orig/linux-2.6/mm/nommu.c 2006-02-17 17:40:34.000000000 +0800
+++ git/linux-2.6/mm/nommu.c 2006-02-20 12:09:32.000000000 +0800
@@ -57,7 +57,10 @@
EXPORT_SYMBOL(vfree);
EXPORT_SYMBOL(vmalloc_to_page);
EXPORT_SYMBOL(vmalloc_32);
+EXPORT_SYMBOL(vmap);
+EXPORT_SYMBOL(vunmap);

+int randomize_va_space = 0;
/*
* Handle all mappings that got truncated by a "truncate()"
* system call.

--
Best regards,
Luke Yang
[email protected]; [email protected]

2006-02-20 05:44:26

by Andrew Morton

Subject: Re: [PATCH] Fix undefined symbols for nommu architecture

"Luke Yang" <[email protected]> wrote:
>
> Hi,
>
> This is a patch to add or export some undefined symbols in nommu
> architectures (mm/nommu.c). Based on latest mm-tree. Following
> symbols are added: vmap, vunmap, randomize_va_space.
>
> Signed-off-by: Luke Yang <[email protected]>
>
> Index: git/linux-2.6/mm/nommu.c
> ===================================================================
> --- git.orig/linux-2.6/mm/nommu.c 2006-02-17 17:40:34.000000000 +0800
> +++ git/linux-2.6/mm/nommu.c 2006-02-20 12:09:32.000000000 +0800
> @@ -57,7 +57,10 @@
> EXPORT_SYMBOL(vfree);
> EXPORT_SYMBOL(vmalloc_to_page);
> EXPORT_SYMBOL(vmalloc_32);
> +EXPORT_SYMBOL(vmap);
> +EXPORT_SYMBOL(vunmap);

OK.

> +int randomize_va_space = 0;

Not so sure about this one. Does randomize_va_space actually make sense in
a nommu environment? I guess we could load relocatable binaries into a
randomised place, but I'm not sure that this is implemented?

If no, then it would make more sense to do

#define randomize_va_space 0

for nommu, so the relevant code gets thrown away by the compiler.

2006-02-20 05:57:17

by Luke Yang

Subject: Re: [PATCH] Fix undefined symbols for nommu architecture

On 2/20/06, Andrew Morton <[email protected]> wrote:
> "Luke Yang" <[email protected]> wrote:
> >
> > Hi,
> >
> > This is a patch to add or export some undefined symbols in nommu
> > architectures (mm/nommu.c). Based on latest mm-tree. Following
> > symbols are added: vmap, vunmap, randomize_va_space.
> >
> > Signed-off-by: Luke Yang <[email protected]>
> >
> > Index: git/linux-2.6/mm/nommu.c
> > ===================================================================
> > --- git.orig/linux-2.6/mm/nommu.c 2006-02-17 17:40:34.000000000 +0800
> > +++ git/linux-2.6/mm/nommu.c 2006-02-20 12:09:32.000000000 +0800
> > @@ -57,7 +57,10 @@
> > EXPORT_SYMBOL(vfree);
> > EXPORT_SYMBOL(vmalloc_to_page);
> > EXPORT_SYMBOL(vmalloc_32);
> > +EXPORT_SYMBOL(vmap);
> > +EXPORT_SYMBOL(vunmap);
>
> OK.
>
> > +int randomize_va_space = 0;
>
> Not so sure about this one. Does randomize_va_space actually make sense in
> a nommu environment? I guess we could load relocatable binaries into a
> randomised place, but I'm not sure that this is implemented?
No, it doesn't make sense now. NOMMU architectures don't really use
it. I put it here just to avoid "undefined symbol" error.
>
> If no, then it would make more sense to do
>
> #define randomize_va_space 0
Yes, this is much better. Do I need to resend a new patch?
>
> for nommu, so the relevant code gets thrown away by the compiler.
>


--
Best regards,
Luke Yang
[email protected]; [email protected]

2006-02-20 06:08:36

by Andrew Morton

Subject: Re: [PATCH] Fix undefined symbols for nommu architecture

"Luke Yang" <[email protected]> wrote:
>
> > Not so sure about this one. Does randomize_va_space actually make sense in
> > a nommu environment? I guess we could load relocatable binaries into a
> > randomised place, but I'm not sure that this is implemented?
> No, it doesn't make sense now. NOMMU architectures don't really use
> it. I put it here just to avoid "undefined symbol" error.
> >
> > If no, then it would make more sense to do
> >
> > #define randomize_va_space 0
> Yes, this is much better. Do I need to resend a new patch?

Yes please - I'm not set up to compile any nommu architectures.