2008-08-06 15:38:24

by Peter Oruba

Subject: [patch 4/5] [PATCH 4/5] x86: Minor correction to Intel microcode patch loader.

Signed-off-by: Peter Oruba <[email protected]>
---
arch/x86/kernel/microcode_intel.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/microcode_intel.c b/arch/x86/kernel/microcode_intel.c
index 4ab6ce3..8d69470 100644
--- a/arch/x86/kernel/microcode_intel.c
+++ b/arch/x86/kernel/microcode_intel.c
@@ -315,7 +315,7 @@ static void apply_microcode(int cpu)
unsigned long flags;
unsigned int val[2];
int cpu_num = raw_smp_processor_id();
- struct ucode_cpu_info *uci = get_ucode_cpu_info(cpu);
+ struct ucode_cpu_info *uci = get_ucode_cpu_info(cpu_num);

/* We should bind the task to the CPU */
BUG_ON(cpu_num != cpu);
--
1.5.4.5

2008-08-11 19:27:46

by Ingo Molnar

Subject: Re: [patch 4/5] [PATCH 4/5] x86: Minor correction to Intel microcode patch loader.

* Peter Oruba <[email protected]> wrote:

> Signed-off-by: Peter Oruba <[email protected]>
> ---
> arch/x86/kernel/microcode_intel.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/microcode_intel.c b/arch/x86/kernel/microcode_intel.c
> index 4ab6ce3..8d69470 100644
> --- a/arch/x86/kernel/microcode_intel.c
> +++ b/arch/x86/kernel/microcode_intel.c
> @@ -315,7 +315,7 @@ static void apply_microcode(int cpu)
> unsigned long flags;
> unsigned int val[2];
> int cpu_num = raw_smp_processor_id();
> - struct ucode_cpu_info *uci = get_ucode_cpu_info(cpu);
> + struct ucode_cpu_info *uci = get_ucode_cpu_info(cpu_num);

hm, this does not apply to tip/x86/microcode nor tip/master nor
linus/master. Does it fix a bug in one of the earlier patches in this
5/5 queue?

Ingo

2008-08-12 14:15:10

by Peter Oruba

Subject: Re: [patch 4/5] [PATCH 4/5] x86: Minor correction to Intel microcode patch loader.

Ingo Molnar schrieb:
> * Peter Oruba <[email protected]> wrote:
>
>> Signed-off-by: Peter Oruba <[email protected]>
>> ---
>> arch/x86/kernel/microcode_intel.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/kernel/microcode_intel.c b/arch/x86/kernel/microcode_intel.c
>> index 4ab6ce3..8d69470 100644
>> --- a/arch/x86/kernel/microcode_intel.c
>> +++ b/arch/x86/kernel/microcode_intel.c
>> @@ -315,7 +315,7 @@ static void apply_microcode(int cpu)
>> unsigned long flags;
>> unsigned int val[2];
>> int cpu_num = raw_smp_processor_id();
>> - struct ucode_cpu_info *uci = get_ucode_cpu_info(cpu);
>> + struct ucode_cpu_info *uci = get_ucode_cpu_info(cpu_num);
>
> hm, this does not apply to tip/x86/microcode nor tip/master nor
> linus/master. Does it fix a bug in one of the earlier patches in this
> 5/5 queue?
>
> Ingo
>
Yes, it's a fix for PATCH 3/5

-Peter

--
| AMD Saxony Limited Liability Company & Co. KG
Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
System | Register Court Dresden: HRA 4896
Research | General Partner authorized to represent:
Center | AMD Saxony LLC (Wilmington, Delaware, US)
| General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy