2008-08-13 22:51:19

by djwong

Subject: [PATCH] coretemp: Recognize Nehalem CPUs

Add in the CPUID for Nehalem chips.

Signed-off-by: Darrick J. Wong <[email protected]>
---

drivers/hwmon/coretemp.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index 70239ac..9f2e423 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -416,7 +416,8 @@ static int __init coretemp_init(void)
/* check if family 6, models 0xe, 0xf, 0x16, 0x17 */
if ((c->cpuid_level < 0) || (c->x86 != 0x6) ||
!((c->x86_model == 0xe) || (c->x86_model == 0xf) ||
- (c->x86_model == 0x16) || (c->x86_model == 0x17))) {
+ (c->x86_model == 0x16) || (c->x86_model == 0x17) ||
+ (c->x86_model == 0x1A))) {

/* supported CPU not found, but report the unknown
family 6 CPU */

2008-08-14 01:13:03

by Kent Liu

Subject: Re: [PATCH] coretemp: Recognize Nehalem CPUs

On Wed, Aug 13, 2008 at 03:51:48PM -0700, Darrick J. Wong wrote:
> Add in the CPUID for Nehalem chips.
>
> Signed-off-by: Darrick J. Wong <[email protected]>
> ---
>
> drivers/hwmon/coretemp.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index 70239ac..9f2e423 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -416,7 +416,8 @@ static int __init coretemp_init(void)
> /* check if family 6, models 0xe, 0xf, 0x16, 0x17 */
This comment should be updated as well to include 0x1A.
> if ((c->cpuid_level < 0) || (c->x86 != 0x6) ||
> !((c->x86_model == 0xe) || (c->x86_model == 0xf) ||
> - (c->x86_model == 0x16) || (c->x86_model == 0x17))) {
> + (c->x86_model == 0x16) || (c->x86_model == 0x17) ||
> + (c->x86_model == 0x1A))) {
>
> /* supported CPU not found, but report the unknown
> family 6 CPU */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

2008-08-14 01:35:48

by djwong

Subject: [PATCH v2] coretemp: Recognize Nehalem CPUs

Add in the CPUID for Nehalem chips.

Signed-off-by: Darrick J. Wong <[email protected]>
---

drivers/hwmon/coretemp.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index 70239ac..93c1722 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -413,10 +413,11 @@ static int __init coretemp_init(void)
for_each_online_cpu(i) {
struct cpuinfo_x86 *c = &cpu_data(i);

- /* check if family 6, models 0xe, 0xf, 0x16, 0x17 */
+ /* check if family 6, models 0xe, 0xf, 0x16, 0x17, 0x1A */
if ((c->cpuid_level < 0) || (c->x86 != 0x6) ||
!((c->x86_model == 0xe) || (c->x86_model == 0xf) ||
- (c->x86_model == 0x16) || (c->x86_model == 0x17))) {
+ (c->x86_model == 0x16) || (c->x86_model == 0x17) ||
+ (c->x86_model == 0x1A))) {

/* supported CPU not found, but report the unknown
family 6 CPU */

2008-08-14 07:14:24

by Rudolf Marek

Subject: Re: [lm-sensors] [PATCH] coretemp: Recognize Nehalem CPUs

Hi Darrick,

Please update the Documentation too. I have patch for the Intel Atom, but this
one seems trivial, so lets push this one first.

Thanks,
Rudolf

2008-08-18 17:56:52

by Rudolf Marek

Subject: Re: [lm-sensors] [PATCH] coretemp: Recognize Nehalem CPUs

Hi again,

Please can you respin the patch with the documentation update, so I can post
updated patch to add Atom to coretemp?

Also please fix the 0x1A to 0x1a.

Thanks,

Rudolf