2008-08-19 04:52:42

by Hiroshi Shimamoto

Subject: [PATCH -tip] rcuclassic: fix compilation NG

From: Hiroshi Shimamoto <[email protected]>

CC kernel/rcuclassic.o
kernel/rcuclassic.c: In function '__rcu_process_callbacks':
kernel/rcuclassic.c:561: error: 'flags' undeclared (first use in this function)
kernel/rcuclassic.c:561: error: (Each undeclared identifier is reported only once
kernel/rcuclassic.c:561: error: for each function it appears in.)
kernel/rcuclassic.c:561: warning: type defaults to 'int' in declaration of '__dummy2'
kernel/rcuclassic.c:561: warning: comparison of distinct pointer types lacks a cast
kernel/rcuclassic.c:561: warning: type defaults to 'int' in declaration of '__dummy2'
kernel/rcuclassic.c:561: warning: comparison of distinct pointer types lacks a cast
kernel/rcuclassic.c:566: warning: type defaults to 'int' in declaration of '__dummy2'
kernel/rcuclassic.c:566: warning: comparison of distinct pointer types lacks a cast
kernel/rcuclassic.c:566: warning: type defaults to 'int' in declaration of '__dummy2'
kernel/rcuclassic.c:566: warning: comparison of distinct pointer types lacks a cast

Declare missing variable flagas.

Signed-off-by: Hiroshi Shimamoto <[email protected]>
---
kernel/rcuclassic.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/rcuclassic.c b/kernel/rcuclassic.c
index c6b6cf5..01e761a 100644
--- a/kernel/rcuclassic.c
+++ b/kernel/rcuclassic.c
@@ -557,6 +557,8 @@ static void __rcu_process_callbacks(struct rcu_ctrlblk *rcp,
local_irq_enable();

if (rcu_batch_after(rdp->batch, rcp->pending)) {
+ unsigned long flags;
+
/* and start it/schedule start if it's a new batch */
spin_lock_irqsave(&rcp->lock, flags);
if (rcu_batch_after(rdp->batch, rcp->pending)) {

2008-08-19 09:03:18

by Ingo Molnar

Subject: Re: [PATCH -tip] rcuclassic: fix compilation NG

* Hiroshi Shimamoto <[email protected]> wrote:

> From: Hiroshi Shimamoto <[email protected]>
>
> CC kernel/rcuclassic.o
> kernel/rcuclassic.c: In function '__rcu_process_callbacks':
> kernel/rcuclassic.c:561: error: 'flags' undeclared (first use in this function)
> kernel/rcuclassic.c:561: error: (Each undeclared identifier is reported only once
> kernel/rcuclassic.c:561: error: for each function it appears in.)

applied, thanks!

Ingo