2008-08-18 19:25:18

by Roel Kluin

Subject: [PATCH] KVM x86_emulate.c: duplicate SrcImm

Hi avi,

you added this in commit 7d858a19efe5844a98e060931570359b70dea6d1
any idea whether it should be replaced by something else?
---
duplicate SrcImm

Signed-off-by: Roel Kluin <[email protected]>
---
diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c
index f2f9046..78b76c9 100644
--- a/arch/x86/kvm/x86_emulate.c
+++ b/arch/x86/kvm/x86_emulate.c
@@ -268,7 +268,7 @@ static u16 group_table[] = {
ByteOp | DstMem | SrcNone | ModRM, ByteOp | DstMem | SrcNone | ModRM,
0, 0, 0, 0,
[Group3*8] =
- DstMem | SrcImm | ModRM | SrcImm, 0,
+ DstMem | SrcImm | ModRM, 0,
DstMem | SrcNone | ModRM, ByteOp | DstMem | SrcNone | ModRM,
0, 0, 0, 0,
[Group4*8] =

2008-08-21 14:38:28

by Avi Kivity

Subject: Re: [PATCH] KVM x86_emulate.c: duplicate SrcImm

roel kluin wrote:
> Hi avi,
>
> you added this in commit 7d858a19efe5844a98e060931570359b70dea6d1
> any idea whether it should be replaced by something else?
> ---
> duplicate SrcImm
>

Right. Applied.

I don't know if some other bit is missing a SrcImm. I'll review that code.


--
error compiling committee.c: too many arguments to function