2008-10-12 07:22:37

by Rufus & Azrael

Subject: [2.6.27-git2] compilation warning for arch/x86/kernel/xsave.c

Hi Suresh,


Your commit ed405958057ca6a8c4c9178a7a3b1167fabb45f5 causes this
compilation warning on xsave.c :

> arch/x86/kernel/xsave.c: In function ‘save_i387_xstate’:
> arch/x86/kernel/xsave.c:98: attention : ignoring return value of
> ‘__clear_user’, declared with attribute warn_unused_result

Regards.

2008-10-13 18:39:53

by Suresh Siddha

Subject: Re: [2.6.27-git2] compilation warning for arch/x86/kernel/xsave.c

On Sun, Oct 12, 2008 at 12:30:17AM -0700, Rufus & Azrael wrote:
> Hi Suresh,
>
>
> Your commit ed405958057ca6a8c4c9178a7a3b1167fabb45f5 causes this
> compilation warning on xsave.c :
>
> > arch/x86/kernel/xsave.c: In function ‘save_i387_xstate’:
> > arch/x86/kernel/xsave.c:98: attention : ignoring return value of
> > ‘__clear_user’, declared with attribute warn_unused_result

Thanks Rufus for the report and thanks Ingo for pushing the fix.

I wonder why CONFIG_ENABLE_MUST_CHECK is not turned on by default?
I turned this option on, in the list of configs I use.

thanks,
suresh

2008-10-13 18:51:18

by Rufus & Azrael

Subject: Re: [2.6.27-git2] compilation warning for arch/x86/kernel/xsave.c

Suresh Siddha wrote:
> On Sun, Oct 12, 2008 at 12:30:17AM -0700, Rufus& Azrael wrote:
>
>> Hi Suresh,
>>
>>
>> Your commit ed405958057ca6a8c4c9178a7a3b1167fabb45f5 causes this
>> compilation warning on xsave.c :
>>
>>
>>> arch/x86/kernel/xsave.c: In function ‘save_i387_xstate’:
>>> arch/x86/kernel/xsave.c:98: attention : ignoring return value of
>>> ‘__clear_user’, declared with attribute warn_unused_result
>>>
>
> Thanks Rufus for the report and thanks Ingo for pushing the fix.
>
> I wonder why CONFIG_ENABLE_MUST_CHECK is not turned on by default?
> I turned this option on, in the list of configs I use.
>
> thanks,
> suresh
>
>
Hi Suresh,


This option is set to Y in my .config, but I don't remember if it was
volontary or by default.

Regards.