2008-10-17 11:13:56

by Zhao Lei

Subject: [PATCH] Fix debugfs_create_*'s error checking method for mips/math-emu/

Hi,

debugfs_create_*() returns NULL if an error occurs, returns -ENODEV
when debugfs is not enabled in the kernel.

Signed-off-by: Zhao Lei <[email protected]>
---
arch/mips/math-emu/cp1emu.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/mips/math-emu/cp1emu.c b/arch/mips/math-emu/cp1emu.c
index b08fc65..7ec0b21 100644
--- a/arch/mips/math-emu/cp1emu.c
+++ b/arch/mips/math-emu/cp1emu.c
@@ -1299,12 +1299,12 @@ static int __init debugfs_fpuemu(void)
if (!mips_debugfs_dir)
return -ENODEV;
dir = debugfs_create_dir("fpuemustats", mips_debugfs_dir);
- if (IS_ERR(dir))
- return PTR_ERR(dir);
+ if (!dir)
+ return -ENOMEM;
for (i = 0; i < ARRAY_SIZE(vars); i++) {
d = debugfs_create_u32(vars[i].name, S_IRUGO, dir, vars[i].v);
- if (IS_ERR(d))
- return PTR_ERR(d);
+ if (!d)
+ return -ENOMEM;
}
return 0;
}
--
1.5.5.3

2008-10-17 14:59:30

by Ralf Baechle

Subject: Re: [PATCH] Fix debugfs_create_*'s error checking method for mips/math-emu/

On Fri, Oct 17, 2008 at 07:12:30PM +0800, Zhaolei wrote:

> debugfs_create_*() returns NULL if an error occurs, returns -ENODEV
> when debugfs is not enabled in the kernel.

Thanks, applied.

Ralf

2008-10-17 15:09:26

by Ralf Baechle

Subject: Re: [PATCH] Fix debugfs_create_*'s error checking method for mips/math-emu/

On Fri, Oct 17, 2008 at 07:12:30PM +0800, Zhaolei wrote:

> debugfs_create_*() returns NULL if an error occurs, returns -ENODEV
> when debugfs is not enabled in the kernel.

Thanks, applied.

Ralf