2008-10-16 17:40:30

by Bryan Wu

Subject: [PATCH 1/1] netdev: DM9000: remove BLACKFIN hacking in DM9000 netdev driver

remove integer casting in the read/write IO accessors,
because Blackfin now provides those functions

Tested-by: Javier Herrero <[email protected]>
Signed-off-by: Bryan Wu <[email protected]>
---
drivers/net/dm9000.c | 9 ---------
1 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
index f42c23f..5a9083e 100644
--- a/drivers/net/dm9000.c
+++ b/drivers/net/dm9000.c
@@ -47,15 +47,6 @@
#define CARDNAME "dm9000"
#define DRV_VERSION "1.31"

-#ifdef CONFIG_BLACKFIN
-#define readsb insb
-#define readsw insw
-#define readsl insl
-#define writesb outsb
-#define writesw outsw
-#define writesl outsl
-#endif
-
/*
* Transmit timeout, default 5 seconds.
*/
--
1.5.6

2008-10-16 18:45:01

by Ben Dooks

Subject: Re: [PATCH 1/1] netdev: DM9000: remove BLACKFIN hacking in DM9000 netdev driver

On Fri, Oct 17, 2008 at 01:40:44AM +0800, Bryan Wu wrote:
> remove integer casting in the read/write IO accessors,
> because Blackfin now provides those functions
>
> Tested-by: Javier Herrero <[email protected]>
> Signed-off-by: Bryan Wu <[email protected]>
Acked-by: Ben Dooks <[email protected]>
> ---
> drivers/net/dm9000.c | 9 ---------
> 1 files changed, 0 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
> index f42c23f..5a9083e 100644
> --- a/drivers/net/dm9000.c
> +++ b/drivers/net/dm9000.c
> @@ -47,15 +47,6 @@
> #define CARDNAME "dm9000"
> #define DRV_VERSION "1.31"
>
> -#ifdef CONFIG_BLACKFIN
> -#define readsb insb
> -#define readsw insw
> -#define readsl insl
> -#define writesb outsb
> -#define writesw outsw
> -#define writesl outsl
> -#endif
> -
> /*
> * Transmit timeout, default 5 seconds.
> */
> --
> 1.5.6
>

--
--
Ben

Q: What's a light-year?
A: One-third less calories than a regular year.

2008-10-21 06:11:39

by Jeff Garzik

Subject: Re: [PATCH 1/1] netdev: DM9000: remove BLACKFIN hacking in DM9000 netdev driver

Bryan Wu wrote:
> remove integer casting in the read/write IO accessors,
> because Blackfin now provides those functions
>
> Tested-by: Javier Herrero <[email protected]>
> Signed-off-by: Bryan Wu <[email protected]>
> ---
> drivers/net/dm9000.c | 9 ---------
> 1 files changed, 0 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
> index f42c23f..5a9083e 100644
> --- a/drivers/net/dm9000.c
> +++ b/drivers/net/dm9000.c
> @@ -47,15 +47,6 @@
> #define CARDNAME "dm9000"
> #define DRV_VERSION "1.31"
>
> -#ifdef CONFIG_BLACKFIN
> -#define readsb insb
> -#define readsw insw
> -#define readsl insl
> -#define writesb outsb
> -#define writesw outsw
> -#define writesl outsl
> -#endif

applied