2008-10-21 15:08:25

by Scott James Remnant

Subject: [PATCH] add MODULE_ALIAS to load ipmi_devintf with ipmi_si

The ipmi_devintf module contains the userspace interface for IPMI
devices, yet will not be loaded automatically with a system
interface handler driver.

Add a MODULE_ALIAS for the "platform:ipmi_si" MODALIAS exported by
the ipmi_si driver, so that userspace knows of the recommendation.

Signed-off-by: Scott James Remnant <[email protected]>
---
drivers/char/ipmi/ipmi_devintf.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
index 64e1c16..ecaf369 100644
--- a/drivers/char/ipmi/ipmi_devintf.c
+++ b/drivers/char/ipmi/ipmi_devintf.c
@@ -957,3 +957,4 @@ module_exit(cleanup_ipmi);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Corey Minyard <[email protected]>");
MODULE_DESCRIPTION("Linux device interface for the IPMI message handler.");
+MODULE_ALIAS("platform:ipmi_si");
--
1.5.6.3

2008-10-21 15:42:36

by Tim Gardner

Subject: Re: [PATCH] add MODULE_ALIAS to load ipmi_devintf with ipmi_si

Scott James Remnant wrote:
> The ipmi_devintf module contains the userspace interface for IPMI
> devices, yet will not be loaded automatically with a system
> interface handler driver.
>
> Add a MODULE_ALIAS for the "platform:ipmi_si" MODALIAS exported by
> the ipmi_si driver, so that userspace knows of the recommendation.
>
> Signed-off-by: Scott James Remnant <[email protected]>
> ---
> drivers/char/ipmi/ipmi_devintf.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
> index 64e1c16..ecaf369 100644
> --- a/drivers/char/ipmi/ipmi_devintf.c
> +++ b/drivers/char/ipmi/ipmi_devintf.c
> @@ -957,3 +957,4 @@ module_exit(cleanup_ipmi);
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Corey Minyard <[email protected]>");
> MODULE_DESCRIPTION("Linux device interface for the IPMI message handler.");
> +MODULE_ALIAS("platform:ipmi_si");

Seems like a candidate for the stable kernel. If you add the line:

Cc: [email protected]

it will happen automagically when Linus merges it into his tree. Can you
resubmit with this line added?

rtg
--
Tim Gardner [email protected]