>From 07463c240c3609c1e2fbed45f64acd5fd061ce58 Mon Sep 17 00:00:00 2001
From: Scott James Remnant <[email protected]>
Date: Tue, 21 Oct 2008 15:18:36 +0100
Subject: [PATCH v2] add MODULE_ALIAS to load ipmi_devintf with ipmi_si
The ipmi_devintf module contains the userspace interface for IPMI
devices, yet will not be loaded automatically with a system
interface handler driver.
Add a MODULE_ALIAS for the "platform:ipmi_si" MODALIAS exported by
the ipmi_si driver, so that userspace knows of the recommendation.
Seems like a candidate for stable kernel updates.
Cc: [email protected]
Signed-off-by: Scott James Remnant <[email protected]>
Signed-off-by: Tim Gardner <[email protected]>
---
drivers/char/ipmi/ipmi_devintf.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
index 64e1c16..ecaf369 100644
--- a/drivers/char/ipmi/ipmi_devintf.c
+++ b/drivers/char/ipmi/ipmi_devintf.c
@@ -957,3 +957,4 @@ module_exit(cleanup_ipmi);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Corey Minyard <[email protected]>");
MODULE_DESCRIPTION("Linux device interface for the IPMI message handler.");
+MODULE_ALIAS("platform:ipmi_si");
--
1.5.6.3
Yes, this is certainly a good idea. I'm not 100% sure of the string,
but it looks reasonable.
Signed-off-by: Corey Minyard <[email protected]>
Tim Gardner wrote:
> From 07463c240c3609c1e2fbed45f64acd5fd061ce58 Mon Sep 17 00:00:00 2001
> From: Scott James Remnant <[email protected]>
> Date: Tue, 21 Oct 2008 15:18:36 +0100
> Subject: [PATCH v2] add MODULE_ALIAS to load ipmi_devintf with ipmi_si
>
> The ipmi_devintf module contains the userspace interface for IPMI
> devices, yet will not be loaded automatically with a system
> interface handler driver.
>
> Add a MODULE_ALIAS for the "platform:ipmi_si" MODALIAS exported by
> the ipmi_si driver, so that userspace knows of the recommendation.
>
> Seems like a candidate for stable kernel updates.
>
> Cc: [email protected]
> Signed-off-by: Scott James Remnant <[email protected]>
> Signed-off-by: Tim Gardner <[email protected]>
> ---
> drivers/char/ipmi/ipmi_devintf.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
> index 64e1c16..ecaf369 100644
> --- a/drivers/char/ipmi/ipmi_devintf.c
> +++ b/drivers/char/ipmi/ipmi_devintf.c
> @@ -957,3 +957,4 @@ module_exit(cleanup_ipmi);
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Corey Minyard <[email protected]>");
> MODULE_DESCRIPTION("Linux device interface for the IPMI message handler.");
> +MODULE_ALIAS("platform:ipmi_si");
>
On Tue, 2008-10-21 at 15:43 -0500, Corey Minyard wrote:
> Yes, this is certainly a good idea. I'm not 100% sure of the string,
> but it looks reasonable.
>
The string matches the one in the platform device created by the ipmi_si
module for each device:
UEVENT[1224021721.100748] add /devices/platform/ipmi_si.0 (platform)
ACTION=add
DEVPATH=/devices/platform/ipmi_si.0
SUBSYSTEM=platform
DRIVER=ipmi_si
MODALIAS=platform:ipmi_si
SEQNUM=2812
You also get an "ipmi_bmc.NNNN.NN" device, with a platform:ipmi_bmc.NNNN
MODALIAS, but it wasn't clear to me what that was.
Scott
--
Scott James Remnant
[email protected]