2008-06-23 13:10:26

by Ryan Hope

Subject: [PATCH -mm] .gitignore for mm-sources is missing critical files

The .gitignore file in the 2.6.26-rc5-mm3 tar ball is incomplete, it
causes many important files to not get added to a git repo. The
patches below fix the issue (sorry they are not all in one diff, it
took me a few try to figure out all the files needed):

diff --git a/f07e4d701ff1fa13f98c21d875f252dc13fa2a42:.gitignore
b/83ad1010c278a37bcd901dde0f7d2b6981f64f6a:.gitignore
index d24ad506e799a5740d19913a333fc9d64261d9c7..9bb1cb6d825d540bc92dfe5c34343438b860b009
100644
--- a/f07e4d701ff1fa13f98c21d875f252dc13fa2a42:.gitignore
+++ b/83ad1010c278a37bcd901dde0f7d2b6981f64f6a:.gitignore
@@ -26,6 +26,7 @@ tags
TAGS
vmlinux*
!vmlinux.lds.S
+!vmlinux.lds.h
System.map
Module.markers
Module.symvers

diff --git a/5ec607502ef909acab4ebe886097523ab4e4e3f5:.gitignore
b/118a64bfe9c4db302820b83a03cc0388f5d620e5:.gitignore
index 9bb1cb6d825d540bc92dfe5c34343438b860b009..71379c18ff4218ba56fd95baf30ac079590ac587
100644
--- a/5ec607502ef909acab4ebe886097523ab4e4e3f5:.gitignore
+++ b/118a64bfe9c4db302820b83a03cc0388f5d620e5:.gitignore
@@ -22,11 +22,15 @@
#
# Top-level generic files
#
+!.mailmap
tags
TAGS
vmlinux*
!vmlinux.lds.S
!vmlinux.lds.h
+!vmlinux_32.lds.S
+!vmlinux_64.lds.S
+!vmlinux.scr
System.map
Module.markers
Module.symvers

diff --git a/118a64bfe9c4db302820b83a03cc0388f5d620e5:.gitignore
b/20c660fa39c48b936c3268dbdf179ff84dbbe365:.gitignore
index 71379c18ff4218ba56fd95baf30ac079590ac587..c50ecc6f3c223b51b856c96009f1b9b6539e163d
100644
--- a/118a64bfe9c4db302820b83a03cc0388f5d620e5:.gitignore
+++ b/20c660fa39c48b936c3268dbdf179ff84dbbe365:.gitignore
@@ -35,6 +35,7 @@ System.map
Module.markers
Module.symvers
!.gitignore
+!*.lds

#
# Generated include files

2008-06-23 16:40:14

by Eduard - Gabriel Munteanu

Subject: Re: [PATCH -mm] .gitignore for mm-sources is missing critical files

On Mon, 23 Jun 2008 09:10:11 -0400
"Ryan Hope" <[email protected]> wrote:

> The .gitignore file in the 2.6.26-rc5-mm3 tar ball is incomplete, it
> causes many important files to not get added to a git repo. The
> patches below fix the issue (sorry they are not all in one diff, it
> took me a few try to figure out all the files needed):

Hi,

> diff --git a/f07e4d701ff1fa13f98c21d875f252dc13fa2a42:.gitignore
> b/83ad1010c278a37bcd901dde0f7d2b6981f64f6a:.gitignore
> index
> d24ad506e799a5740d19913a333fc9d64261d9c7..9bb1cb6d825d540bc92dfe5c34343438b860b009
> 100644 --- a/f07e4d701ff1fa13f98c21d875f252dc13fa2a42:.gitignore
> +++ b/83ad1010c278a37bcd901dde0f7d2b6981f64f6a:.gitignore
> @@ -26,6 +26,7 @@ tags
> TAGS
> vmlinux*
> !vmlinux.lds.S
> +!vmlinux.lds.h
> System.map
> Module.markers
> Module.symvers

Check v2.6.26-rc7, I submitted a patch a few days ago and it's already
in. Well, just this hunk.

> diff --git a/5ec607502ef909acab4ebe886097523ab4e4e3f5:.gitignore
> b/118a64bfe9c4db302820b83a03cc0388f5d620e5:.gitignore
> index
> 9bb1cb6d825d540bc92dfe5c34343438b860b009..71379c18ff4218ba56fd95baf30ac079590ac587
> 100644 --- a/5ec607502ef909acab4ebe886097523ab4e4e3f5:.gitignore
> +++ b/118a64bfe9c4db302820b83a03cc0388f5d620e5:.gitignore
> @@ -22,11 +22,15 @@
> #
> # Top-level generic files
> #
> +!.mailmap
> tags
> TAGS
> vmlinux*
> !vmlinux.lds.S
> !vmlinux.lds.h
> +!vmlinux_32.lds.S
> +!vmlinux_64.lds.S
> +!vmlinux.scr
> System.map
> Module.markers
> Module.symvers
>
> diff --git a/118a64bfe9c4db302820b83a03cc0388f5d620e5:.gitignore
> b/20c660fa39c48b936c3268dbdf179ff84dbbe365:.gitignore
> index
> 71379c18ff4218ba56fd95baf30ac079590ac587..c50ecc6f3c223b51b856c96009f1b9b6539e163d
> 100644 --- a/118a64bfe9c4db302820b83a03cc0388f5d620e5:.gitignore
> +++ b/20c660fa39c48b936c3268dbdf179ff84dbbe365:.gitignore
> @@ -35,6 +35,7 @@ System.map
> Module.markers
> Module.symvers
> !.gitignore
> +!*.lds
>
> #
> # Generated include files

I'd suggest finding a nice regexp/wildcard to unmask these or to fix
the "vmlinux*" line (likely better). Running 'find . -name vmlinux\*'
shows a few more things that may be prone to exclusion to that rule and
shouldn't.

I already feel bad I didn't fix this more thoroughly when I had the
chance :-). Then again, I stumbled on this while working on another
project and I didn't feel like dwelling on other problems. Go ahead and
save the day :P.


Cheers,
Eduard