2020-12-31 03:30:10

by Wesley Sheng

[permalink] [raw]
Subject: [PATCH] PCI:tegra:Correct typo for PCIe endpoint mode in Tegra194

In config PCIE_TEGRA194_EP the mode incorrectly referred to
host mode.

Signed-off-by: Wesley Sheng <[email protected]>
---
drivers/pci/controller/dwc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 044a3761c44f..6960babe6161 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -273,7 +273,7 @@ config PCIE_TEGRA194_EP
select PCIE_TEGRA194
help
Enables support for the PCIe controller in the NVIDIA Tegra194 SoC to
- work in host mode. There are two instances of PCIe controllers in
+ work in endpoint mode. There are two instances of PCIe controllers in
Tegra194. This controller can work either as EP or RC. In order to
enable host-specific features PCIE_TEGRA194_HOST must be selected and
in order to enable device-specific features PCIE_TEGRA194_EP must be
--
2.16.2


2021-01-03 06:50:13

by Vidya Sagar

[permalink] [raw]
Subject: Re: [PATCH] PCI:tegra:Correct typo for PCIe endpoint mode in Tegra194

Thanks for the patch.

Acked-by: Vidya Sagar <[email protected]>

On 12/31/2020 8:55 AM, Wesley Sheng wrote:
> External email: Use caution opening links or attachments
>
>
> In config PCIE_TEGRA194_EP the mode incorrectly referred to
> host mode.
>
> Signed-off-by: Wesley Sheng <[email protected]>
> ---
> drivers/pci/controller/dwc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 044a3761c44f..6960babe6161 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -273,7 +273,7 @@ config PCIE_TEGRA194_EP
> select PCIE_TEGRA194
> help
> Enables support for the PCIe controller in the NVIDIA Tegra194 SoC to
> - work in host mode. There are two instances of PCIe controllers in
> + work in endpoint mode. There are two instances of PCIe controllers in
> Tegra194. This controller can work either as EP or RC. In order to
> enable host-specific features PCIE_TEGRA194_HOST must be selected and
> in order to enable device-specific features PCIE_TEGRA194_EP must be
> --
> 2.16.2
>

2021-03-08 07:43:01

by Krzysztof Wilczyński

[permalink] [raw]
Subject: Re: [PATCH] PCI:tegra:Correct typo for PCIe endpoint mode in Tegra194

Hi,

A small nitpick. There are spaces missing in the subject line.

[...]
> Enables support for the PCIe controller in the NVIDIA Tegra194 SoC to
> - work in host mode. There are two instances of PCIe controllers in
> + work in endpoint mode. There are two instances of PCIe controllers in
> Tegra194. This controller can work either as EP or RC. In order to
> enable host-specific features PCIE_TEGRA194_HOST must be selected and
> in order to enable device-specific features PCIE_TEGRA194_EP must be
[...]

Nice catch! Thank you!

Reviewed-by: Krzysztof Wilczyński <[email protected]>

Krzysztof

2021-03-22 18:22:04

by Lorenzo Pieralisi

[permalink] [raw]
Subject: Re: [PATCH] PCI:tegra:Correct typo for PCIe endpoint mode in Tegra194

On Thu, 31 Dec 2020 11:25:39 +0800, Wesley Sheng wrote:
> In config PCIE_TEGRA194_EP the mode incorrectly referred to
> host mode.

Applied to pci/tegra, thanks!

[1/1] PCI: tegra: Fix typo for PCIe endpoint mode in Tegra194
https://git.kernel.org/lpieralisi/pci/c/10739e2a5e

Thanks,
Lorenzo