2008-11-16 09:44:20

by Qinghuang Feng

[permalink] [raw]
Subject: [PATCH 1/7] drivers/ata/pata_radisys.c: cleanup kernel-doc

No argument named @isich in radisys_set_dmamode,
remove it.

Signed-off-by: Qinghuang Feng <[email protected]>
---
diff --git a/drivers/ata/pata_radisys.c b/drivers/ata/pata_radisys.c
index 0b0aa45..695d44a 100644
--- a/drivers/ata/pata_radisys.c
+++ b/drivers/ata/pata_radisys.c
@@ -81,7 +81,6 @@ static void radisys_set_piomode (struct ata_port *ap, struct ata_device *adev)
* radisys_set_dmamode - Initialize host controller PATA DMA timings
* @ap: Port whose timings we are configuring
* @adev: Device to program
- * @isich: True if the device is an ICH and has IOCFG registers
*
* Set MWDMA mode for device, in host controller PCI config space.
*


2008-11-17 17:44:21

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH 1/7] drivers/ata/pata_radisys.c: cleanup kernel-doc

On Sun, 16 Nov 2008 17:43:46 +0800 Qinghuang Feng wrote:

> No argument named @isich in radisys_set_dmamode,
> remove it.
>
> Signed-off-by: Qinghuang Feng <[email protected]>

patches 1-7:
Acked-by: Randy Dunlap <[email protected]>

I'll leave them for Jeff to merge.

Thanks.

---
~Randy

2008-11-25 16:39:26

by Jeff Garzik

[permalink] [raw]
Subject: Re: [PATCH 1/7] drivers/ata/pata_radisys.c: cleanup kernel-doc

Qinghuang Feng wrote:
> No argument named @isich in radisys_set_dmamode,
> remove it.
>
> Signed-off-by: Qinghuang Feng <[email protected]>
> ---
> diff --git a/drivers/ata/pata_radisys.c b/drivers/ata/pata_radisys.c
> index 0b0aa45..695d44a 100644
> --- a/drivers/ata/pata_radisys.c
> +++ b/drivers/ata/pata_radisys.c
> @@ -81,7 +81,6 @@ static void radisys_set_piomode (struct ata_port *ap, struct ata_device *adev)
> * radisys_set_dmamode - Initialize host controller PATA DMA timings
> * @ap: Port whose timings we are configuring
> * @adev: Device to program
> - * @isich: True if the device is an ICH and has IOCFG registers
> *
> * Set MWDMA mode for device, in host controller PCI config space.
> *

applied 1-7 to #upstream, after combining into a single patch. I felt a
single changeset was more appropriate.

2008-11-25 17:00:50

by sniper

[permalink] [raw]
Subject: Re: [PATCH 1/7] drivers/ata/pata_radisys.c: cleanup kernel-doc

> applied 1-7 to #upstream, after combining into a single patch. I felt a
> single changeset was more appropriate.
>
Hello sir,

That's good, but.
Andrew Morton have got these patches few days ago, and he forgot to Cc to you.
These patches are in mm-trees now. I don't know if it will lead to some problem,
so send this mail to you.